Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Djava.io.tmpdir parameter in jvm.options to add quotes #21

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Update Djava.io.tmpdir parameter in jvm.options to add quotes #21

merged 1 commit into from
Mar 14, 2019

Conversation

ebadyano
Copy link
Contributor

After elasticsearch change, ${ES_TMPDIR} needs quotes around it.

Relates elastic/elasticsearch#39959

@ebadyano
Update Djava.io.tmpdir parameter in jvm.options to add quotes
18da6d5 
After elasticsearch change, ${ES_TMPDIR} needs quotes around it.

Relates elastic/elasticsearch#39959
@ebadyano ebadyano requested a review from dliappis March 14, 2019 15:39
dliappis
dliappis approved these changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If this ends up being required without a follow-up change in master/7 we'll need to back this commit to branch 7 of rally-teams too.

@ebadyano ebadyano merged commit 9d01d65 into elastic:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebadyano @dliappis