Skip to content
This repository has been archived by the owner on Jan 27, 2023. It is now read-only.

[snapshot] First APM package ever #688

Merged
merged 4 commits into from
Dec 10, 2020

Conversation

jalvz
Copy link

@jalvz jalvz commented Dec 7, 2020

🎉

@jalvz jalvz requested review from axw and simitt December 7, 2020 09:37
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 7, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #688 updated

  • Start Time: 2020-12-10T13:58:32.145+0000

  • Duration: 11 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 56
Skipped 0
Total 56

@jalvz
Copy link
Author

jalvz commented Dec 7, 2020

@ruflin @mtojek lint is failing because it needs elastic/package-registry#656, which is not yet into the last tagged version of the registry.

I'd like to merge this asap to start "serious testing ™️": is it ok to do it before releasing a new registry version, or something bad will happen?
OTOH, when should we expect a new registry/spec release?

@ruflin
Copy link
Contributor

ruflin commented Dec 7, 2020

I suggest we just do a new release of the registry and spec today? @mtojek @ycombinator Do you see any problem with that?

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jalvz
Copy link
Author

jalvz commented Dec 8, 2020

I suggest we just do a new release of the registry and spec today?

@ruflin @mtojek @ycombinator who usually takes care of that, and/or where are the docs for that matter? - ie. any specific release procedure beyond tagging the latest commit?

@mtojek mtojek self-requested a review December 9, 2020 08:32
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's first make this PR green.

It looks like there is a problem with validation: no support for traces. I suppose that's because of not bumped up revision in the package storage repository (Dockerfile: https://github.com/elastic/package-storage/blob/snapshot/Dockerfile#L7).

Here are the steps on how to prepare and release the next revision of package-registry: https://github.com/elastic/package-registry#release

@mtojek mtojek requested a review from ruflin December 9, 2020 08:37
@ruflin
Copy link
Contributor

ruflin commented Dec 9, 2020

@jalvz Can you prepare a new release for the registry? @mtojek Can you assist him?

@jalvz
Copy link
Author

jalvz commented Dec 9, 2020

It looks like there is a problem with validation: no support for traces. I suppose that's because of not bumped up revision

Exactly, that's why we need a release first (see #688 (comment))

PR up: elastic/package-registry#661

@jalvz jalvz changed the title First APM package ever [snapshot] First APM package ever Dec 10, 2020
@jalvz
Copy link
Author

jalvz commented Dec 10, 2020

This is green now, thanks all. Can some of you have a look at 4322c24 ?

@mtojek mtojek self-requested a review December 10, 2020 11:42
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is green, LGTM!

Keep in mind that you'll have to adjust also other branches (staging, production) with the updated registry version.

@ph
Copy link
Contributor

ph commented Dec 10, 2020

This is great! !

@jalvz jalvz merged commit be67809 into elastic:snapshot Dec 10, 2020
thomasneirynck pushed a commit to thomasneirynck/package-storage that referenced this pull request Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants