-
Notifications
You must be signed in to change notification settings - Fork 102
Conversation
@ruflin @mtojek I'd like to merge this asap to start "serious testing ™️": is it ok to do it before releasing a new registry version, or something bad will happen? |
I suggest we just do a new release of the registry and spec today? @mtojek @ycombinator Do you see any problem with that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@ruflin @mtojek @ycombinator who usually takes care of that, and/or where are the docs for that matter? - ie. any specific release procedure beyond tagging the latest commit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's first make this PR green.
It looks like there is a problem with validation: no support for traces. I suppose that's because of not bumped up revision in the package storage repository (Dockerfile: https://github.com/elastic/package-storage/blob/snapshot/Dockerfile#L7).
Here are the steps on how to prepare and release the next revision of package-registry: https://github.com/elastic/package-registry#release
Exactly, that's why we need a release first (see #688 (comment)) PR up: elastic/package-registry#661 |
This is green now, thanks all. Can some of you have a look at 4322c24 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI is green, LGTM!
Keep in mind that you'll have to adjust also other branches (staging, production) with the updated registry version.
This is great! ! |
🎉