-
Notifications
You must be signed in to change notification settings - Fork 102
Add barracuda/0.1.0 integration (snapshot) #152
Add barracuda/0.1.0 integration (snapshot) #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall effect looks good, only some nit-picks. Did you try to run this one and see the results in the UI? We used to publish a screenshot from Kibana UI to present the configuration form.
After this one, I'll add the next 19 rsa2elk devices in a single PR if possible. They all follow the exact same structure than this one.
It's fine, you can combine these integrations together.
keep_raw: {{keep_raw_fields}} | ||
debug: {{debug}} | ||
source: | | ||
// Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nchaulet @michalpristas Could you please confirm that such huge blobs should be supported by all parties?
title: Collect logs from Barracuda Web Application Firewall via file | ||
description: Collecting syslog from Barracuda Web Application Firewall via file. | ||
# No icon | ||
icon: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure we can easily find a barracuda svg to dump on here, is there a reason not to add an icon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaik we don't have (yet) clearance from Barracuda for the use of their logo in a commercial product. I see a lot of logos in other packages, @mtojek is someone from the ingest manager team handling this? /cc @jamiehynds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nobody. Currently used logos are imported from existing open-source repos of Elastic. In general in terms of the ingest manager, the point of contact is @ruflin .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I pulled the logo from https://www.elastic.co/integrations for my WIP integration. Even though I once went to law school, IANAL, so not entirely sure what additional consent we need from those other companies for inclusion of their logos here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to @jamiehynds we're OK adding the logos. Will update the PR.
This adds the yamlpipeline package with 3 ingest pipelines in yaml. Closes elastic/package-registry#150
This adds the first rsa2elk integration package for Barracuda WAF devices.
After this one, I'll add the next 19 rsa2elk devices in a single PR if possible. They all follow the exact same structure than this one.
Screenshots
With logo: