This repository has been archived by the owner on Jan 27, 2023. It is now read-only.
Remove packages as master is not production anymore #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only opening as draft at the moment as I'm pretty sure there will be also other side effects in the integrations and package-registry repo that first need to be sorted out. @mtojek FYI |
ruflin
added a commit
to ruflin/package-registry
that referenced
this pull request
Jul 2, 2020
As the master branch will not contain any packages anymore in the future, the packages used to run the registry locally must be adjusted. See elastic/package-storage#116 for more details.
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
ruflin
added a commit
to elastic/package-registry
that referenced
this pull request
Jul 2, 2020
As the master branch will not contain any packages anymore in the future, the packages used to run the registry locally must be adjusted. See elastic/package-storage#116 for more details.
As part of elastic#86 the master branch will not be used anymore. By now, all packages have been moved over to the production branch and it is ready to be deployed under `epr.elastic.co`. All future contributions of packages should go to the production branch or as soon as staging and snapshot deployment are fully available + promotion script, follow the new process. This PR removes all packages and big junk of the code. Further cleanup will be needed. The goal of this PR is to make sure this registry is not used anymore moving forward.
ruflin
force-pushed
the
remove-packages-from-master
branch
from
80dbf6e to
c399eef
Compare
|
Opened for review as I think all the dependencies in package-registry should be removed now. |
|
I was wondering if this is the moment, when the entire master branch can be deleted? |
|
@mtojek My thinking was that the master/main branch will become more a landing page of this repository. Explaining the branches and who things are promoted etc. Lets get first this PR in to make sure the branch is not used for packages anymore and then follow up. |
|
We can also consider a different approach here - add explanation to README files and set "production" as default branch. |
mtojek
approved these changes
Jul 3, 2020
|
I filed as a follow up so we don't forget: #120 |
thomasneirynck
pushed a commit
to thomasneirynck/package-storage
that referenced
this pull request
Sep 28, 2021
Before all endpoints had the same cache time. But search and categories should have a shorter cache time then the catchAll endpoint which serves the static files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #86 the master branch will not be used anymore. By now, all packages have been moved over to the production branch and it is ready to be deployed under
epr.elastic.co. All future contributions of packages should go to the production branch or as soon as staging and snapshot deployment are fully available + promotion script, follow the new process.This PR removes all packages and big junk of the code. Further cleanup will be needed. The goal of this PR is to make sure this registry is not used anymore moving forward.