Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support expanded and flat objects #56

Merged
merged 5 commits into from
Oct 6, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Oct 6, 2020

Issue: #55

For ease of merging, I branched out from this PR: #54 (if that's an issue I can branch from master).

@mtojek mtojek requested a review from ycombinator October 6, 2020 12:09
@mtojek mtojek self-assigned this Oct 6, 2020
@mtojek
Copy link
Contributor Author

mtojek commented Oct 6, 2020

This is another place where mapstr.go is needed. I think we need to put it in a good place.

@elasticmachine
Copy link

elasticmachine commented Oct 6, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #56 updated]

  • Start Time: 2020-10-06T14:30:08.725+0000

  • Duration: 2 min 11 sec

@ycombinator
Copy link
Contributor

ycombinator commented Oct 6, 2020

For ease of merging, I branched out from this PR: #54 (if that's an issue I can branch from master).

It depends on how much longer we're going to wait on #54, which depends on how much longer we want to wait for the associated ES issue to at least be triaged.

I would prefer to branch this PR (#56) from master so there's no dependency on #54. It will also make reviewing this PR easier 🙂.

@mtojek
Copy link
Contributor Author

mtojek commented Oct 6, 2020

I was thinking the other way round. Let's consider #54 as workaround and once the discussion with ES is finalized we'll adjust the implementation, but I don't mind splitting these PRs.

@ycombinator
Copy link
Contributor

That plan also works for me. In that case don’t bother splitting out this PR. I will review #54 now so we can get it in shortly. Then you can just rebase this PR on master.

@mtojek
Copy link
Contributor Author

mtojek commented Oct 6, 2020

Ok, I rebased against master. It's ready for review.

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mtojek mtojek merged commit bc98b6b into elastic:master Oct 6, 2020
rw-access pushed a commit to rw-access/package-spec that referenced this pull request Mar 23, 2021
* Write version to file

* Use unix timestamp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants