-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support expanded and flat objects #56
Conversation
This is another place where |
It depends on how much longer we're going to wait on #54, which depends on how much longer we want to wait for the associated ES issue to at least be triaged. I would prefer to branch this PR (#56) from |
I was thinking the other way round. Let's consider #54 as workaround and once the discussion with ES is finalized we'll adjust the implementation, but I don't mind splitting these PRs. |
That plan also works for me. In that case don’t bother splitting out this PR. I will review #54 now so we can get it in shortly. Then you can just rebase this PR on |
Ok, I rebased against master. It's ready for review. |
code/go/internal/validator/test/packages/missing_pipeline_dashes/manifest.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* Write version to file * Use unix timestamp
Issue: #55
For ease of merging, I branched out from this PR: #54 (if that's an issue I can branch from master).