Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove newlines filter_condition setting #534

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Remove newlines filter_condition setting #534

merged 1 commit into from
Jun 8, 2023

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Jun 8, 2023

Fix definition of the filter_condition, removing the newline character.

@mrodm mrodm self-assigned this Jun 8, 2023
@mrodm mrodm requested a review from a team as a code owner June 8, 2023 15:28
@mrodm mrodm changed the title Remove newlines filter_enabled Remove newlines filter_condition setting Jun 8, 2023
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-08T15:28:57.983+0000

  • Duration: 7 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 842
Skipped 0
Total 842

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 68.966% (20/29) 👍
Classes 73.171% (30/41) 👍
Methods 56.154% (73/130) 👍
Lines 43.029% (679/1578) 👍
Conditionals 100.0% (0/0) 💚

@mrodm mrodm merged commit 5e86c23 into elastic:main Jun 8, 2023
@mrodm mrodm deleted the remove_newlines_filter branch June 8, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

Assignees

@mrodm mrodm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrodm @elasticmachine @jlind23