Add setting to configure the source mode of a data stream #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kpollich depending on the outcome of this PR we may need a follow up on elastic/kibana#140095. |
ruflin
reviewed
Sep 15, 2022
ruflin
reviewed
Sep 15, 2022
|
Overall LGTM, left 2 minor questions. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
kpollich
previously approved these changes
Sep 21, 2022
There was a problem hiding this comment.
LGTM 🚀
I created elastic/kibana#141211 to capture Fleet support for this.
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add setting to configure the source mode of a data stream.
Why is it important?
Depending on the use case, deciding how to store the source may bring important disk space savings or perfomance improvements.
This allows to enable
_syntheticsource for a data stream.We may want to decide on a general default for the source mode depending on the results of the technical review implemented in elastic/kibana#140095, but we will still need a toggle in the package for exceptions (#340 (comment)).
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues
_sourceto data streams kibana#140095.