-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CUE to define schema for files #391
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🌐 Coverage report
|
Closing in favor of #384. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses CUE to define the schema for files instead of JSON schema (only integration manifest and changelog by now).
It includes #384 for semantic rules versioning.
Thoughts on using CUE for schema validation
TLDR; I am not convinced that it provides general advantages.
Pros:
Cons:
fs.FS
(cue/load: support loading from io/fs.FS cue-lang/cue#607). Hacks needed.internal
libraries. No custom Go logic or types can be added, we'd need to fork or continue with semantic validation. Same limitations in that sense than jsonschema at the end.Why is it important?
To support multiple versions of the spec with the same files.
Checklist
test/packages
that prove my change is effective.versions/N/changelog.yml
.Related issues