Fix package validation on Windows #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
jsoriano
force-pushed
the
test-on-windows
branch
2 times, most recently
from
1e3c1e7
to
eb514b5
Compare
v1v
reviewed
Jun 22, 2022
jsoriano
force-pushed
the
test-on-windows
branch
from
eb514b5
to
a58cb94
Compare
v1v
reviewed
Jun 22, 2022
jsoriano
force-pushed
the
test-on-windows
branch
from
a58cb94
to
9c56f07
Compare
v1v
reviewed
Jun 22, 2022
v1v
reviewed
Jun 22, 2022
v1v
reviewed
Jun 22, 2022
jsoriano
changed the title
mtojek
approved these changes
Jun 23, 2022
| @@ -23,3 +23,5 @@ require ( | |||
| github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f // indirect | |||
| golang.org/x/tools v0.0.0-20200130002326-2f3ba24bd6e7 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/xeipuuv/gojsonschema => github.com/elastic/gojsonschema v1.2.1-0.20220622182608-92eeb544ec83 | |||
There was a problem hiding this comment.
It took me a while to find that there were a problem there 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use
pathinstead ofpath/filepathfor operations on paths for files infs.FSfilesystems.fs.FSuses/as path separator also in Windows, so operations with paths in these filesystems should be done withpathinstead offilepath.Add a fork for
gojsonschemawith a fix for references on Windows usingfs.FS.A new testing stage is added for Windows to validate these changes.
Why is it important?
To fix validation of packages in Windows.
Checklist
test/packagesthat prove my change is effective.versions/N/changelog.yml.Related issues