Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags to allow for routing to dynamic datasets and namespaces #327

Merged
merged 10 commits into from
Nov 17, 2022
Merged

Add flags to allow for routing to dynamic datasets and namespaces #327

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
85c55c3
Add elasticsearch.privileges.allow_routing flag
felixbarny Apr 29, 2022
a765a87
Fix PR number
felixbarny Apr 29, 2022
45fd7c4
Move allow_routing to top level
felixbarny May 2, 2022
f0ea035
Apply suggestions from review
felixbarny May 4, 2022
b6daaf0
Apply suggestions from code review
felixbarny May 4, 2022
3346b91
Merge remote-tracking branch 'origin/main' into add-allow_routing
felixbarny Nov 16, 2022
7ac2d24
Rename flag to dynamic_dataset/dynamic_namespace
felixbarny Nov 16, 2022
deda84b
Move to elasticsearch (from elasticsearch.privileges)
felixbarny Nov 16, 2022
5d3945c
Merge branch 'main' into add-allow_routing
jsoriano Nov 16, 2022
b52f844
Merge branch 'main' into add-allow_routing
jsoriano Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/packages/good/data_stream/foo/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
title: Nginx access logs
type: logs
allow_routing: true
felixbarny marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is related to elasticsearch configuration, I think it could be at the root level of elasticsearch, even if it doesn't belong to the elasticsearch.privileges object #327 (comment).

We did something similar for the time series mode in https://github.com/elastic/package-spec/pull/357/files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixbarny is this change still required? Wdyt about placing this parameter under elasticsearch object?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is still required. Are all the blockers resolved now? I don’t care so much about where the flag is. Happy to change it to be under elasticsearch if you think that’s a better place.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This blocker was solved elastic/kibana#115032, not sure if there were any others.

Yes, please update the branch to put the new setting under elasticsearch. We removed the versions directory, so you will also need to move the changes to the new structure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved it and renamed and split the property so that it's both more self-explanatory and flexible.

streams:
- input: logfile
vars:
Expand Down
3 changes: 3 additions & 0 deletions versions/1/integration/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
- description: Add Kibana/osquery-saved-query
type: enhancement
link: https://github.com/elastic/package-spec/pull/321
- description: Add "allow_routing" to data stream manifest
type: enhancement
link: https://github.com/elastic/package-spec/pull/327
- version: 1.7.0
changes:
- description: Add kibana/osquery-pack-asset
Expand Down
3 changes: 3 additions & 0 deletions versions/1/integration/data_stream/manifest.spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@ spec:
hidden:
description: Specifies if a data stream is hidden
type: boolean
allow_routing:
description: When set to true, the package is granted data stream privileges for all datasets and namespaces of its type
felixbarny marked this conversation as resolved.
Show resolved Hide resolved
type: boolean
streams:
description: Streams offered by data stream.
type: array
Expand Down