-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add elasticsearch.privileges.cluster support #226
Conversation
@mtojek I interpreted this sentence:
to mean that I should make my changes in the top-level manifest.yml. If this is wrong let me know! |
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
@joshdover Requested your review on this from a Fleet perspective to make sure it will work as expected in Kibana. Ideally we would have the Kibana PR already open in parallel. |
Thanks. I'm going to delegate this to @nchaulet since he's working on elastic/kibana#114686 already. |
Based on the work being done in elastic/kibana#114945, are we ok with the nesting? @joshdover @nchaulet |
@@ -106,6 +106,21 @@ spec: | |||
- "1.0.0-SNAPSHOT" | |||
- "1.0.0-dev.1" | |||
properties: | |||
elasticsearch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that these properties are more or less sorted in prioritized order, which means that "elasticsearch" as extension should be at the bottom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stuartnelson3 this one is still not addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I have a working PR with that for Kibana and the package registry and looks like it's working 👍
This PR hasn't received all approvals and got merged. There is also an unaddressed comment. |
What does this PR do?
add an optional
elasticsearch.cluster
property to the package manifest to define cluster privileges to be assigned to an api keyWhy is it important?
APM server needs additional cluster privileges to access
/
on its elasticsearch outputChecklist
test/packages
that prove my change is effective.versions/N/changelog.yml
.Related issues
proposed in #224