Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate format checkers #161

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Relocate format checkers #161

merged 3 commits into from
Apr 27, 2021

Conversation

ycombinator
Copy link
Contributor

What does this PR do?

This PR relocates the format checkers implementation into the new semantic package.

Why is it important?

With this change, all non-declarative package validation rules are contained in a single place, the semantic package. This will make porting such rules to another language easier.

Checklist

Related issues

@elasticmachine
Copy link

elasticmachine commented Apr 21, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #161 updated

  • Start Time: 2021-04-27T07:54:11.537+0000

  • Duration: 2 min 15 sec

  • Commit: 3d4f25f

Trends 🧪

Image of Build Times

@ycombinator ycombinator marked this pull request as ready for review April 26, 2021 21:47
@ycombinator ycombinator requested a review from mtojek April 26, 2021 21:47
mtojek
mtojek reviewed Apr 27, 2021
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is everything alright with this PR? I see it includes changes introduced in 92ee6e4 . Is that intended?

@ycombinator
Copy link
Contributor Author

@mtojek Ah, good catch. I made this PR before #160 was merged. It needs a rebase on master. That's why I had left this PR in draft mode but I forgot about that and put it into review yesterday 🤦. Rebasing on master now...

@ycombinator ycombinator force-pushed the relocate-format-checkers branch from 4cdc60a to 50c5034 Compare April 27, 2021 07:28
@ycombinator ycombinator requested a review from mtojek April 27, 2021 07:28
mtojek
mtojek approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be confusing for users that this semantic validator requires special handling - Load/Unload. I would be for adjusting it to the concept func do() validationErrors, but I don't think it's easy. Let's merge this one!

code/go/internal/validator/folder_item_spec.go Outdated
@@ -8,6 +8,8 @@ import (
"regexp"
"sync"

"github.com/elastic/package-spec/code/go/internal/validator/semantic"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: sorting imports

@ycombinator ycombinator merged commit 322a039 into elastic:master Apr 27, 2021
@ycombinator ycombinator deleted the relocate-format-checkers branch April 27, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ycombinator @elasticmachine @mtojek