Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predefining available input groups #158

Merged
merged 4 commits into from
Apr 9, 2021
Merged

Predefining available input groups #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f94e1f
Predefining available input groups
ycombinator Apr 8, 2021
471e688
Adding CHANGELOG entry
ycombinator Apr 8, 2021
639fb78
Updating specs
ycombinator Apr 8, 2021
f6a7253
Updating test packages
ycombinator Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/go/internal/spec/statik.go
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 0 additions & 7 deletions test/packages/input_groups/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,5 @@ policy_templates:
- name: barracuda_foobar_property
type: bool
title: Barracuda Specific Property
input_groups:
- name: logs
title: "Logs"
description: "Collect logs from AWS service"
- name: metrics
title: "Metrics"
description: "Collect metrics from AWS service"
owner:
github: elastic/integrations-platforms
7 changes: 0 additions & 7 deletions test/packages/input_groups_bad_data_stream/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,5 @@ policy_templates:
- name: barracuda_foobar_property
type: bool
title: Barracuda Specific Property
input_groups:
- name: logs
title: "Logs"
description: "Collect logs from AWS service"
- name: metrics
title: "Metrics"
description: "Collect metrics from AWS service"
owner:
github: elastic/integrations-platforms
3 changes: 3 additions & 0 deletions versions/1/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,6 @@
- description: Make input groups language consistent.
type: bugfix
link: https://github.com/elastic/package-spec/pull/157
- description: Predefine input groups
type: breaking-change
link: https://github.com/elastic/package-spec/pull/158
33 changes: 1 addition & 32 deletions versions/1/manifest.spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,36 +169,6 @@ spec:
description: Kibana versions compatible with this package.
examples:
- ">=7.9.0"
input_groups:
description: List of input groups offered by this package.
type: array
items:
type: object
additionalProperties: false
properties:
name:
description: Name of input group.
type: string
pattern: '[a-z][a-z_]+'
examples:
- logs
- metrics
title:
description: Title of input group.
type: string
examples:
- Access Logs
- Health Metrics
description:
description: Longer description of the input group.
type: string
examples:
- Collect logs from AWS service
- Collect metrics from AWS service
required:
- name
- title
- description
policy_templates:
description: List of policy templates offered by this package.
type: array
Expand Down Expand Up @@ -262,8 +232,7 @@ spec:
input_group:
description: Name of the input group
type: string
pattern: '[a-z][a-z_]+'
examples:
enum:
- logs
- metrics
multi:
Expand Down