Adding CI setup files #13
Conversation
| cleanup() | ||
| withMageEnv(){ | ||
| dir("${BASE_DIR}"){ | ||
| sh(label: 'Check',script: 'make check') |
There was a problem hiding this comment.
| sh(label: 'Check',script: 'make check') | |
| sh(label: 'Check', script: 'make check') |
Tiny nit: Missing space
| cleanup() | ||
| withMageEnv(){ | ||
| dir("${BASE_DIR}"){ | ||
| sh(label: 'Check',script: 'make test') |
There was a problem hiding this comment.
| sh(label: 'Check',script: 'make test') | |
| sh(label: 'Check', script: 'make test') |
Tiny nit: missing space
| cleanup() | ||
| withMageEnv(){ | ||
| dir("${BASE_DIR}"){ | ||
| sh(label: 'Check',script: 'make test') |
There was a problem hiding this comment.
What output does make test produce? Is it something that needs to be processed with junit?
There was a problem hiding this comment.
At the moment make test will simply run go test -v ./... under the hood: https://github.com/elastic/package-spec/pull/12/files#diff-d635a9f292641eeeb317ef8c83354e7dR16
Would it be better if it output in a junit-compatible format? We could certainly make that happen with something like https://github.com/jstemmer/go-junit-report.
|
Sorry @cachedout, I saw your comments after I saw Marcin's LGTM so I merged the PR already. I will make a follow up PR to address your feedback. |
|
@ycombinator No worries! Thanks. |
This PR creates the
.cifolder and adds the necessary files under it to setup Jenkins CI jobs for this repository.Follow up to #12.
Resolves #6.