Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package validator in typescript #58

Closed
8 tasks
skh opened this issue Oct 13, 2020 · 2 comments
Closed
8 tasks

Add package validator in typescript #58

skh opened this issue Oct 13, 2020 · 2 comments

Comments

@skh
Copy link

skh commented Oct 13, 2020

To be able to use the package validation from this repository in EPM in Kibana, we need to publish an npm package to the @elastic namespace on https://www.npmjs.com/ . From there, we can import the package in Kibana like any other npm package.

Publishing to npmjs.com can be done manually whenever we have a release.

  • Create a subdirectory code/typescript
  • create a standard npm package there
  • implement a stub validator
  • add tests & integrate into CI of this repository
  • document how to use a local checkout of the validator in a local checkout of kibana for development
  • publish to npm
  • automate publishing to npm?
  • implement the real validator
@skh skh self-assigned this Oct 13, 2020
@skh skh removed their assignment Oct 26, 2020
@skh
Copy link
Author

skh commented Oct 28, 2020

cc @jfsiii

Feel free to adjust the initial description, this is mostly a brain dump of mine.

rw-access pushed a commit to rw-access/package-spec that referenced this issue Mar 23, 2021
* Implement "format" subcommand

* Unmarshal, marshal

* Fix: make check

* Add PR comments

* Flags as consts

* Use yaml.v3 for marshalling

* Fix

* Find best indentation

* Add comments

* Move flag labels to captions

* Address PR comments

* Adjust indents

* Register test runners
@jen-huang jen-huang closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2023
@jen-huang
Copy link
Contributor

Closing as won't fix: we haven't come across the need for this in the past few years, so the effort of doing this work won't provide much benefits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants