Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discuss] Impact of renaming config to policy #19

Closed
ruflin opened this issue Aug 12, 2020 · 7 comments
Closed

[Discuss] Impact of renaming config to policy #19

ruflin opened this issue Aug 12, 2020 · 7 comments
Assignees
Labels
Team:Fleet Label for the Fleet team

Comments

@ruflin
Copy link
Contributor

ruflin commented Aug 12, 2020

It was decided to rename Agent Config to Agent Policy. This also applies to all config blocks inside the config blocks inside the config, which are now also policies.

The main usage of config inside the package spec seems to be config_template which could become policy_template instead.

@ruflin ruflin self-assigned this Aug 12, 2020
@ruflin
Copy link
Contributor Author

ruflin commented Aug 12, 2020

@mtojek @ycombinator Thoughts on the above? Perhaps this is also an opportunity to find a better name?

@mtojek
Copy link
Contributor

mtojek commented Aug 12, 2020

It was decided to rename Agent Config to Agent Policy. This also applies to all config blocks inside the config blocks inside the config, which are now also policies.

It would be valuable to put a sample config here as the description is a bit blurry. What are the policies? How much do they differ from what we have now?

@ruflin
Copy link
Contributor Author

ruflin commented Aug 13, 2020

Policy = Config. There is no difference form a pure yaml perspective structure except the name. One thing that changes is if dataset.* was used inside the stream templates it now has to be data_stream.*, but this is specific to each package and only effected the log package so far.

@ycombinator
Copy link
Contributor

Yeah, I'm also not 100% clear on what are agent configs in relation to packages. To put it differently: where exactly in packages do agent configs show up? It might be helpful to post some links to agent configs in existing packages.

@ruflin
Copy link
Contributor Author

ruflin commented Aug 17, 2020

An example config can be found here: https://github.com/elastic/beats/blob/master/x-pack/elastic-agent/elastic-agent.yml But lets also try to talk it through, I organised a meeting tomorrow and then we follow up here.

@ruflin ruflin added the Team:Fleet Label for the Fleet team label Sep 18, 2020
@ycombinator
Copy link
Contributor

@ruflin @mtojek I think we can close this now thanks to #50?

@mtojek
Copy link
Contributor

mtojek commented Sep 30, 2020

Yes. Resolving.

@mtojek mtojek closed this as completed Sep 30, 2020
rw-access pushed a commit to rw-access/package-spec that referenced this issue Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Label for the Fleet team
Projects
None yet
Development

No branches or pull requests

3 participants