Use defer to disable warnings as errors in test

elastic · Aug 18, 2022 · d78a905 · d78a905
1 parent e8a9c56
commit d78a905
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/code/go/pkg/validator/validator_test.go b/code/go/pkg/validator/validator_test.go
@@ -319,6 +319,8 @@ func TestValidateWarnings(t *testing.T) {
 	if err := common.EnableWarningsAsErrors(); err != nil {
 		require.NoError(t, err)
 	}
+	defer common.DisableWarningsAsErrors()
+
 	for pkgName, expectedWarnContains := range tests {
 		t.Run(pkgName, func(t *testing.T) {
 			warnPrefix := fmt.Sprintf("Warning: ")
@@ -347,9 +349,6 @@ func TestValidateWarnings(t *testing.T) {
 			}
 		})
 	}
-	if err := common.DisableWarningsAsErrors(); err != nil {
-		require.NoError(t, err)
-	}
 }
 
 func requireErrorMessage(t *testing.T, pkgName string, invalidItemsPerFolder map[string][]string, expectedErrorMessage string) {