Fixing return type

code/go/internal/validator/semantic/kibana_matching_object_ids.go

@@ -19,14 +19,16 @@ import (
 // object files that define IDs not matching the file's name. That is, it returns
 // validation errors if a Kibana object file, foo.json, in the package defines
 // an object ID other than foo inside it.
-func ValidateKibanaObjectIDs(pkgRoot string) error {
+func ValidateKibanaObjectIDs(pkgRoot string) ve.ValidationErrors {
+	var errs ve.ValidationErrors
+
 	filePaths := filepath.Join(pkgRoot, "kibana", "*", "*.json")
 	objectFiles, err := pkgpath.Files(filePaths)
 	if err != nil {
-		return errors.Wrap(err, "unable to find Kibana object files")
+		errs = append(errs, errors.Wrap(err, "error finding Kibana object files"))
+		return errs
 	}
 
-	var errs ve.ValidationErrors
 	for _, objectFile := range objectFiles {
 		name := objectFile.Name()
 		objectID, err := objectFile.Values("$.id")

code/go/internal/validator/semantic/kibana_no_dangling_object_ids.go

@@ -4,12 +4,14 @@
 
 package semantic
 
+import "github.com/elastic/package-spec/code/go/internal/errors"
+
 // ValidateKibanaNoDanglingObjectIDs returns validation errors if there are any
 // dangling references to Kibana objects in any Kibana object files. That is, it
 // returns validation errors if a Kibana object file in the package references another
 // Kibana object with ID i, but no Kibana object file for object ID i is found in the
 // package.
-func ValidateKibanaNoDanglingObjectIDs(pkgRoot string) error {
+func ValidateKibanaNoDanglingObjectIDs(pkgRoot string) errors.ValidationErrors {
 	// TODO: will be implemented in follow up PR
 	return nil
 }