Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for requirements in package manifest #574

Merged
merged 4 commits into from
Jul 1, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Remove `removable` flag from package manifest. [#532](https://github.com/elastic/package-registry/pull/532)
* Rename `datasources` to `config_templates` in dataset manifest. [#570](https://github.com/elastic/package-registry/pull/570)
* Remove support for logs and metrics category. [#571](https://github.com/elastic/package-registry/pull/571)
* Remove `dataset.type: event` as suported type. [#](https://github.com/elastic/package-registry/pull/)
* Remove `dataset.type: event` as suported type. [#567](https://github.com/elastic/package-registry/pull/567)
* Remove support for requirements. Use conditions instead. [#574](https://github.com/elastic/package-registry/pull/574)

### Bugfixes

Expand Down
2 changes: 1 addition & 1 deletion testdata/generated/example-0.0.2.tar.gz-preview.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@
1995 example-0.0.2/kibana/visualization/7e4084e0-5c99-11e9-8477-077ec9664dbd.json
1849 example-0.0.2/kibana/visualization/80844540-5c97-11e9-8477-077ec9664dbd.json
1920 example-0.0.2/kibana/visualization/ab48c3f0-5ca6-11e9-8477-077ec9664dbd.json
195 example-0.0.2/manifest.yml
193 example-0.0.2/manifest.yml
5 changes: 0 additions & 5 deletions testdata/generated/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@
"conditions": {
"kibana.version": "~7.x.x"
},
"requirement": {
"kibana": {
"versions": "\u003e=7.0.0"
}
},
"screenshots": [
{
"src": "/package/example/1.0.0/img/kibana-iptables.png",
Expand Down
5 changes: 0 additions & 5 deletions testdata/generated/package/base/0.2.0/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@
"conditions": {
"kibana.version": "\u003e7.9.0"
},
"requirement": {
"kibana": {
"versions": "\u003e7.9.0"
}
},
"assets": [
"/package/base/0.2.0/manifest.yml",
"/package/base/0.2.0/docs/README.md",
Expand Down
3 changes: 0 additions & 3 deletions testdata/generated/package/datasources/1.0.0/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@
"custom"
],
"release": "beta",
"requirement": {
"kibana": {}
},
"assets": [
"/package/datasources/1.0.0/manifest.yml",
"/package/datasources/1.0.0/docs/README.md",
Expand Down
3 changes: 0 additions & 3 deletions testdata/generated/package/default_pipeline/0.0.2/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@
"message_queue"
],
"release": "beta",
"requirement": {
"kibana": {}
},
"assets": [
"/package/default_pipeline/0.0.2/manifest.yml",
"/package/default_pipeline/0.0.2/docs/README.md",
Expand Down
3 changes: 0 additions & 3 deletions testdata/generated/package/ecs_style_dataset/0.0.1/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@
"monitoring"
],
"release": "beta",
"requirement": {
"kibana": {}
},
"assets": [
"/package/ecs_style_dataset/0.0.1/manifest.yml",
"/package/ecs_style_dataset/0.0.1/docs/README.md",
Expand Down
5 changes: 0 additions & 5 deletions testdata/generated/package/example/0.0.2/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@
"conditions": {
"kibana.version": "\u003e=6.0.0"
},
"requirement": {
"kibana": {
"versions": "\u003e=6.0.0"
}
},
"assets": [
"/package/example/0.0.2/manifest.yml",
"/package/example/0.0.2/docs/README.md",
Expand Down
5 changes: 0 additions & 5 deletions testdata/generated/package/example/1.0.0/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@
"conditions": {
"kibana.version": "~7.x.x"
},
"requirement": {
"kibana": {
"versions": "\u003e=7.0.0"
}
},
"screenshots": [
{
"src": "/package/example/1.0.0/img/kibana-iptables.png",
Expand Down
3 changes: 0 additions & 3 deletions testdata/generated/package/experimental/0.0.1/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@
"aws"
],
"release": "experimental",
"requirement": {
"kibana": {}
},
"assets": [
"/package/experimental/0.0.1/manifest.yml",
"/package/experimental/0.0.1/docs/README.md"
Expand Down
5 changes: 0 additions & 5 deletions testdata/generated/package/foo/1.0.0/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@
"conditions": {
"kibana.version": "\u003e=7.0.0"
},
"requirement": {
"kibana": {
"versions": "\u003e=7.0.0"
}
},
"assets": [
"/package/foo/1.0.0/manifest.yml",
"/package/foo/1.0.0/docs/README.md"
Expand Down
3 changes: 0 additions & 3 deletions testdata/generated/package/internal/1.2.0/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@
"license": "basic",
"categories": [],
"release": "beta",
"requirement": {
"kibana": {}
},
"assets": [
"/package/internal/1.2.0/manifest.yml",
"/package/internal/1.2.0/docs/README.md"
Expand Down
5 changes: 0 additions & 5 deletions testdata/generated/package/longdocs/1.0.4/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@
"conditions": {
"kibana.version": "\u003e6.7.0"
},
"requirement": {
"kibana": {
"versions": "\u003e6.7.0"
}
},
"assets": [
"/package/longdocs/1.0.4/manifest.yml",
"/package/longdocs/1.0.4/docs/README.md",
Expand Down
3 changes: 0 additions & 3 deletions testdata/generated/package/metricsonly/2.0.1/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@
"custom"
],
"release": "ga",
"requirement": {
"kibana": {}
},
"assets": [
"/package/metricsonly/2.0.1/manifest.yml",
"/package/metricsonly/2.0.1/docs/README.md",
Expand Down
3 changes: 0 additions & 3 deletions testdata/generated/package/multiple_false/0.0.1/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@
"custom"
],
"release": "beta",
"requirement": {
"kibana": {}
},
"assets": [
"/package/multiple_false/0.0.1/manifest.yml",
"/package/multiple_false/0.0.1/docs/README.md",
Expand Down
5 changes: 0 additions & 5 deletions testdata/generated/package/multiversion/1.0.3/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@
"conditions": {
"kibana.version": "\u003e6.7.0"
},
"requirement": {
"kibana": {
"versions": "\u003e6.7.0"
}
},
"assets": [
"/package/multiversion/1.0.3/changelog.yml",
"/package/multiversion/1.0.3/manifest.yml",
Expand Down
5 changes: 0 additions & 5 deletions testdata/generated/package/multiversion/1.0.4/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@
"conditions": {
"kibana.version": "\u003e6.7.0"
},
"requirement": {
"kibana": {
"versions": "\u003e6.7.0"
}
},
"assets": [
"/package/multiversion/1.0.4/changelog.yml",
"/package/multiversion/1.0.4/manifest.yml",
Expand Down
3 changes: 0 additions & 3 deletions testdata/generated/package/multiversion/1.1.0/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@
"conditions": {
"kibana.version": "\u003e6.7.0"
},
"requirement": {
"kibana": {}
},
"assets": [
"/package/multiversion/1.1.0/changelog.yml",
"/package/multiversion/1.1.0/manifest.yml",
Expand Down
3 changes: 0 additions & 3 deletions testdata/generated/package/no_stream_configs/1.0.0/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@
"custom"
],
"release": "beta",
"requirement": {
"kibana": {}
},
"assets": [
"/package/no_stream_configs/1.0.0/manifest.yml",
"/package/no_stream_configs/1.0.0/docs/README.md",
Expand Down
5 changes: 0 additions & 5 deletions testdata/generated/package/reference/1.0.0/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@
"conditions": {
"kibana.version": "\u003e6.7.0 \u003c7.6.0"
},
"requirement": {
"kibana": {
"versions": "\u003e6.7.0 \u003c7.6.0"
}
},
"assets": [
"/package/reference/1.0.0/changelog.yml",
"/package/reference/1.0.0/manifest.yml",
Expand Down
3 changes: 0 additions & 3 deletions testdata/generated/package/yamlpipeline/1.0.0/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@
"custom"
],
"release": "beta",
"requirement": {
"kibana": {}
},
"assets": [
"/package/yamlpipeline/1.0.0/manifest.yml",
"/package/yamlpipeline/1.0.0/docs/README.md",
Expand Down
4 changes: 2 additions & 2 deletions testdata/package/base/0.2.0/manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ license: basic
# This is called type integration because it is required for all the integration packages
type: integration

requirement:
conditions:
kibana:
# Requires ILM which was released in 6.6.
versions: ">7.9.0"
version: ">7.9.0"

# No icons
icons:
Expand Down
4 changes: 2 additions & 2 deletions testdata/package/example/0.0.2/manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ version: 0.0.2
categories: ["web"]
release: beta

requirement:
conditions:
kibana:
versions: ">=6.0.0"
version: ">=6.0.0"
4 changes: 0 additions & 4 deletions testdata/package/example/1.0.0/manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ owner.github: "ruflin"
conditions:
kibana.version: "~7.x.x"

requirement:
kibana:
versions: ">=7.0.0"

screenshots:
- src: /img/kibana-iptables.png
title: IP Tables Overview dashboard
Expand Down
4 changes: 2 additions & 2 deletions testdata/package/foo/1.0.0/manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ categories: ["custom"]
type: solution
release: beta

requirement:
conditions:
kibana:
versions: ">=7.0.0"
version: ">=7.0.0"

4 changes: 2 additions & 2 deletions testdata/package/longdocs/1.0.4/manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ categories: ["custom", "web"]
release: ga
license: basic

requirement:
conditions:
kibana:
versions: ">6.7.0"
version: ">6.7.0"

icons:
- src: "/img/icon.svg"
Expand Down
4 changes: 2 additions & 2 deletions testdata/package/multiversion/1.0.3/manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ categories: ["custom", "web"]
release: ga
license: basic

requirement:
conditions:
kibana:
versions: ">6.7.0"
version: ">6.7.0"

icons:
- src: "/img/icon.svg"
Expand Down
4 changes: 2 additions & 2 deletions testdata/package/multiversion/1.0.4/manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ release: ga
license: basic
type: integration

requirement:
conditions:
kibana:
versions: ">6.7.0"
version: ">6.7.0"

icons:
- src: "/img/icon.svg"
Expand Down
4 changes: 2 additions & 2 deletions testdata/package/multiversion/1.1.0/manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ categories: ["custom", "web"]
release: ga
license: basic

requirement:
conditions:
kibana:
versions: ">6.7.0"
version: ">6.7.0"

icons:
- src: "/img/icon.svg"
Expand Down
7 changes: 0 additions & 7 deletions testdata/package/reference/1.0.0/manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,6 @@ owner:
conditions:
kibana.version: ">6.7.0 <7.6.0"

requirement:
kibana:
versions: ">6.7.0 <7.6.0"
elasticsearch:
versions: ">7.0.1"


compatibility: [1.0.2, 2.0.1]
os.platform: [darwin, freebsd, linux, macos, openbsd, windows]

Expand Down
Loading