Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create base-fields.yml files #494

Merged
merged 3 commits into from
Jun 4, 2020
Merged

Do not create base-fields.yml files #494

merged 3 commits into from
Jun 4, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Jun 4, 2020 •
edited
Loading

Changes:

  • don't create base-fields.yml files (only validate)
  • add missing base-fields.yml files

Issue: #465 (comment)

@mtojek mtojek requested a review from ruflin June 4, 2020 08:09
@mtojek mtojek self-assigned this Jun 4, 2020
@elasticmachine
Copy link

elasticmachine commented Jun 4, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #494 updated]

  • Start Time: 2020-06-04T09:18:23.398+0000

  • Duration: 4 min 25 sec

@mtojek
Copy link
Contributor Author

mtojek commented Jun 4, 2020

We should observe green status of the CI once changes in package-storage are merged

@ruflin
Copy link
Member

ruflin commented Jun 4, 2020

I wonder of the order we should do the changes. Getting this in before #492 means we will have to update the storage twice (also existing packages). But we should not get #492 in before Agent and Kibana are updated :-(

ruflin
ruflin approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a quick chat and decided the upcoming renaming should not block this change.

@mtojek
Copy link
Contributor Author

mtojek commented Jun 4, 2020

jenkins test this please

@mtojek mtojek merged commit 21cd9e4 into elastic:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtojek @elasticmachine @ruflin