-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update custom log package #449
Conversation
@@ -5,3 +5,5 @@ paths: | |||
{{/each}} | |||
|
|||
dataset: {{dataset}} | |||
|
|||
{{custom}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nchaulet I tried to have a fully custom part in this config here. When I try to fill it in with foo: bar
in the UI I get the following error:
can not read an implicit mapping pair; a colon is missed at line 7, column 13: "##custom##" ^
If would assume it replaced {{custom}}
by foo: bar
so it should be valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This a good scenario that we did not cover, I did the compilation of yaml to be able to support values like custom: {{custom}}
Thinking of the solution we have:
- We can probably add a new concept in the registry variables, to flag a variable that should be spread to the agent yaml.
- we can try to detect in the template that custom is a root level yaml value and do another special treatment, I have a POC here [Ingest] Support root level yaml variables in agent stream template kibana#66120
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ on option 2 as I would prefer to have as few "types" as possible on the package level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
No description provided.