-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON responses contain key with dot in 'kibana.version' #730
Labels
Comments
andrewkroh
added a commit
to andrewkroh/package-registry
that referenced
this issue
Sep 22, 2021
This changes the response JSON from ``` "conditions": { "kibana.version": "^7.15.0" }, ``` to ``` "conditions": { "kibana": { "version": "^7.15.0" } }, ``` Closes elastic#730
andrewkroh
added a commit
to andrewkroh/package-registry
that referenced
this issue
Sep 22, 2021
This changes the response JSON from ``` "conditions": { "kibana.version": "^7.15.0" }, ``` to ``` "conditions": { "kibana": { "version": "^7.15.0" } }, ``` Closes elastic#730
andrewkroh
added a commit
to andrewkroh/package-registry
that referenced
this issue
Sep 22, 2021
This changes the response JSON from ``` "conditions": { "kibana.version": "^7.15.0" }, ``` to ``` "conditions": { "kibana": { "version": "^7.15.0" } }, ``` Closes elastic#730
andrewkroh
added a commit
to andrewkroh/package-registry
that referenced
this issue
Sep 22, 2021
This changes the response JSON from ``` "conditions": { "kibana.version": "^7.15.0" }, ``` to ``` "conditions": { "kibana": { "version": "^7.15.0" } }, ``` Closes elastic#730
I did a search in Kibana and didn't find anything reading the value. Probably it has no need to read the value because it can query using |
I assume you are right but lets @joshdover confirm it. There are some scripts that use the API but I doubt any of these uses the "output" value at the moment. |
andrewkroh
added a commit
that referenced
this issue
Sep 29, 2021
This changes the response JSON from ``` "conditions": { "kibana.version": "^7.15.0" }, ``` to ``` "conditions": { "kibana": { "version": "^7.15.0" } }, ``` Closes #730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The response from the
/package
endpoint uses a key name that contains a dot. It's not common to use field names that contain dots and this might lead to confusion when processing the response data. For example theelastic-package
tool would not unmarshal this field if it were returned.Example: https://epr.elastic.co/package/gcp/1.1.0/
My preferred representation would be
It should be easy to fix the package-registry, but changing it could break clients. So are there any clients using this field? I can check Kibana, but is that the only user?
The text was updated successfully, but these errors were encountered: