Fix Kafka and Collector config for macs #74
Conversation
Neither were working right, in the case of kafka this disables some problematic tracing options and in the case of the collector this fixes the config yaml
docker-compose.yml
Outdated
| @@ -618,6 +613,7 @@ services: | |||
| - OTEL_RESOURCE_ATTRIBUTES | |||
| - OTEL_SERVICE_NAME=kafka | |||
| - KAFKA_HEAP_OPTS=-Xmx400m -Xms400m | |||
| - OTEL_INFERRED_SPANS_ENABLED=false | |||
There was a problem hiding this comment.
I tried just changing this in the Dockerfile for the image, but even after deleting the image it was still there.
There was a problem hiding this comment.
I think this will be the demo uses the public published images by default: https://github.com/elastic/opentelemetry-demo/pkgs/container/opentelemetry-demo
To test it locally, you would need to rebuild the image and override the image name in the corresponding docker-compose
There was a problem hiding this comment.
@andrewvc Thanks for adding this!
I see that most of the changes are in the docker-compose.yml file, which we try not to change/diverge from the upstream fork. The upstream repository is heavily forked and to improve the maintainability (we have nightly auto-syncs) the forked versions rely mostly on environment variables, specifically the .env.override file. Another example is the Dockerfiles to generate the images, to override the OpenTelemetry agent with the Elastic distribution one, we added some custom Dockerfile.elastic in the corresponding directories instead of changing the upstream one.
Could you move the OTEL_INFERRED_SPANS_ENABLED=false to the src/kafka/Dockerfile.elastic file? We will build and publish the new images asap.
Also, could you undo the formatting changes in the docker-compose file in this PR? I think it would be better suited for an upstream PR
docker-compose.yml
Outdated
| @@ -618,6 +613,7 @@ services: | |||
| - OTEL_RESOURCE_ATTRIBUTES | |||
| - OTEL_SERVICE_NAME=kafka | |||
| - KAFKA_HEAP_OPTS=-Xmx400m -Xms400m | |||
| - OTEL_INFERRED_SPANS_ENABLED=false | |||
There was a problem hiding this comment.
I think this will be the demo uses the public published images by default: https://github.com/elastic/opentelemetry-demo/pkgs/container/opentelemetry-demo
To test it locally, you would need to rebuild the image and override the image name in the corresponding docker-compose
|
I see that |
|
@rogercoll I've reverted the docker-compose changes! |
Neither were working right, in the case of kafka this disables some problematic tracing options and in the case of the collector this fixes the config yaml