Switch Python services to Elastic OTel distribution

[xrmx]

Changes

Switch recommendationservice and loadgenerator to Elastic OTel distribution

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

• CHANGELOG.md updated to document new feature additions
• Appropriate documentation updates in the docs
• Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

[xrmx]

This is completely untested but I don't expect surprises :)

[xrmx]

• Need to update loadgenerator too that for some reasons is using a very old distro

[rogercoll]

Thanks for adding this, just a small comment regarding if we should push these changes upstream too

[xrmx]

No new signals just dependencies of our distro. I think the version bump is fine for upstream too even if it's not latest. Il gio 8 ago 2024, 17:13 Roger Coll ***@***.***> ha scritto:

…

***@***.**** commented on this pull request. Thanks for adding this, just a small comment regarding if we should push these changes upstream too ------------------------------ In src/loadgenerator/requirements.txt <#41 (comment)> : > +opentelemetry-exporter-otlp-proto-common==1.25.0 +opentelemetry-exporter-otlp-proto-grpc==1.25.0 +opentelemetry-exporter-otlp-proto-http==1.25.0 Will these dependencies create extra signals? I am wondering if it would make sense adding them into the upstream repository instead — Reply to this email directly, view it on GitHub <#41 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAADFBHNM6GX6O5VSX2DN5LZQODKVAVCNFSM6AAAAABL2SHKZOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMRYGE4DMNBXGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[rogercoll]

@xrmx Wdyt moving the version bump into the upstream repository? (we have automated syncs, and we try to avoid conflicts as much as possible)

I would just keep the Elastic's specific here elastic-opentelemetry==0.1.0

[xrmx]

@xrmx Wdyt moving the version bump into the upstream repository? (we have automated syncs, and we try to avoid conflicts as much as possible)

I would just keep the Elastic's specific here elastic-opentelemetry==0.1.0

I've opened a PR here https://github.com/open-telemetry/opentelemetry-demo/pull/1705 but since the version of the sdk our distro depends on is not always synced with theirs or latest upstream, conflicts will happen anyway. Another source of conflicts is that the distro depends on more packages that the one they are installing.

[rogercoll]

@xrmx I was reviewing the conflicts in the loadgenerator requirements file and noticed that the distro package depends on more packages than the one being installed. Specifically, it seems that we are adding the opentelemetry-exporter-otlp, opentelemetry-exporter-otlp-proto-common, and opentelemetry-exporter-otlp-proto-http packages.

I was wondering if you could help me understand the purpose of these additions. Do these dependencies introduce additional attributes or signals to the loadgenerator service? I'm also curious about the reason behind including them in the requirements file.

[xrmx]

@xrmx I was reviewing the conflicts in the loadgenerator requirements file and noticed that the distro package depends on more packages than the one being installed. Specifically, it seems that we are adding the opentelemetry-exporter-otlp, opentelemetry-exporter-otlp-proto-common, and opentelemetry-exporter-otlp-proto-http packages.

I was wondering if you could help me understand the purpose of these additions. Do these dependencies introduce additional attributes or signals to the loadgenerator service? I'm also curious about the reason behind including them in the requirements file.

The additions come from our distro dependency on opentelemetry-exporter-otlp. I added that to avoid users to to have to install the otlp exporters explicitly. Currently our distro dependencies are the following:

dependencies = [
    "opentelemetry-api == 1.25.0",
    "opentelemetry-exporter-otlp == 1.25.0",
    "opentelemetry-instrumentation == 0.46b0",
    "opentelemetry-instrumentation-system-metrics == 0.46b0",
    "opentelemetry-semantic-conventions == 0.46b0",
    "opentelemetry-sdk == 1.25.0",
]

Which by chance matches what is in the upstream repository of this fork but I'll bump the dependency on 1.27.0 once it is out.