Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Elastic demo images for Helm deployment #29

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

rogercoll
Copy link
Collaborator

Changes

Changes default Helm image value to use Elastic's images.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@rogercoll rogercoll force-pushed the override_helm_image branch from e5dc3aa to 88cd1af Compare June 21, 2024 16:02
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any kind of documentation of how this work and how it could be overridden?

@rogercoll
Copy link
Collaborator Author

Do we have any kind of documentation of how this work and how it could be overridden?

This value is used to replace the image source used in the Helm chart: https://github.com/open-telemetry/opentelemetry-helm-charts/tree/main/charts/opentelemetry-demo#default-parameters-applied-to-all-demo-components

Currently, we are just documenting the instructions to launch our overwritten values: https://github.com/elastic/opentelemetry-demo?tab=readme-ov-file#start-the-demo

I am working on another PR to disable opensearch and modify the collector's configuration in the same file, if it works for you, I will add a contributing/changes section in the README to denote all overwritten values in that PR.

@rogercoll rogercoll merged commit 60009c4 into elastic:main Jun 25, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants