feat: add Elastic OpenTelemetry Node.js distribution #21
Conversation
| @@ -7,27 +7,28 @@ | |||
| "scripts": { | |||
| "test": "echo \"Error: no test specified\" && exit 1", | |||
| "lint": "semistandard *.js", | |||
| "start": "node --require ./opentelemetry.js index.js" | |||
| "start": "OTEL_EXPORTER_OTLP_PROTOCOL=grpc node --require @elastic/opentelemetry-node index.js" | |||
There was a problem hiding this comment.
do you plant to remove opentelemetry.js file? If so there are several dependencies that are recommended to delete to avoid version conflicts with dependencies declared in @elastic/opentelemetry-node. In fact they could be deleted and opentelemetry.js would still work.
The list of deps becomes the one below
{
"name": "paymentservice",
...
"dependencies": {
"@elastic/opentelemetry-node": "^0.2.0",
"@grpc/grpc-js": "1.10.8",
"@grpc/proto-loader": "0.7.13",
"@openfeature/flagd-provider": "0.13.0",
"@openfeature/server-sdk": "1.14.0",
"@opentelemetry/api": "1.8.0",
"@opentelemetry/auto-instrumentations-node": "0.46.1",
"grpc-js-health-check": "1.1.0",
"pino": "8.16.1",
"simple-card-validator": "1.1.0",
"uuid": "9.0.1"
}
}There was a problem hiding this comment.
Good catch! Let's remove it so the difference is more visible too. Fixed in f5a79b4
There was a problem hiding this comment.
This also includes a bunch of changes that aren't directly about switching to the Elastic Node.js distro. Is that intentional?
There was a problem hiding this comment.
No, I guess those changes were shown due to the automatic main branch rebase. 😞
Branch rebased.
src/paymentservice/package.json
Outdated
| "@opentelemetry/resource-detector-aws": "1.5.0", | ||
| "@opentelemetry/resource-detector-container": "0.3.9", | ||
| "@opentelemetry/resource-detector-gcp": "0.29.9", | ||
| "@opentelemetry/auto-instrumentations-node": "0.46.1", |
There was a problem hiding this comment.
This dep could also be removed. The @elastic/opentelemetry-node includes any instrumentations that it supports as dependencies itself.
There was a problem hiding this comment.
Thanks for catching this! Removed in 72a8b3c
The payment service has been modified to use the Elastic's OpenTelemetry Distribution for Node.js instead of the upstream version.
* feat: add Elastic OpenTelemetry Node.js distribution The payment service has been modified to use the Elastic's OpenTelemetry Distribution for Node.js instead of the upstream version. * remove opentelemetry.js file and dependencies * remove auto instrumentation dependency
The payment service has been modified to use the Elastic's OpenTelemetry Distribution for Node.js instead of the upstream version.
Changes
Please provide a brief description of the changes here.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
* [ ]CHANGELOG.mdupdated to document new feature additions* [ ] Appropriate documentation updates in the docs* [ ] Appropriate Helm chart updates in the helm-chartsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.