Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update images for 7.14 to reflect Amsterdam EUI theme #912

Merged
merged 2 commits into from
Aug 2, 2021

Conversation

EamonnTP
Copy link
Contributor

@EamonnTP EamonnTP commented Jul 29, 2021

Description

This PR updates images for 7.14 which reflect the new default Amsterdam EUI theme.

Using the release cluster and a cloud deployment I was able to update most of the images.

Still outstanding are images in the following topics:

Docs preview

Sample (APM): https://observability-docs_912.docs-preview.app.elstc.co/guide/en/observability/master/apm.html

Related issue

#911

@EamonnTP EamonnTP added Team:Docs Label for the Observability docs team v7.14.0 labels Jul 29, 2021
@EamonnTP EamonnTP requested a review from a team July 29, 2021 13:16
@EamonnTP EamonnTP self-assigned this Jul 29, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Jul 29, 2021

A documentation preview will be available soon:

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. My only concern would be with the website used for the user experience screenshots. I'm not sure we want to publicize those numbers. You might want to double-check before merging this. I'm not sure with who though.

@EamonnTP
Copy link
Contributor Author

EamonnTP commented Aug 2, 2021

This LGTM. My only concern would be with the website used for the user experience screenshots. I'm not sure we want to publicize those numbers. You might want to double-check before merging this. I'm not sure with who though.

Good point. I updated the image to use a test website instead.

@EamonnTP EamonnTP merged commit f055daa into elastic:master Aug 2, 2021
@EamonnTP EamonnTP deleted the update-images-7-14 branch August 2, 2021 15:35
EamonnTP pushed a commit to EamonnTP/observability-docs that referenced this pull request Aug 2, 2021
* Update images for 7.14

* Update user exp tab image
EamonnTP pushed a commit to EamonnTP/observability-docs that referenced this pull request Aug 2, 2021
* Update images for 7.14

* Update user exp tab image
EamonnTP pushed a commit that referenced this pull request Aug 2, 2021
* Update images for 7.14

* Update user exp tab image
EamonnTP pushed a commit that referenced this pull request Aug 2, 2021
* Update images for 7.14

* Update user exp tab image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Docs Label for the Observability docs team v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants