Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Agent/Fleet Server environment variables #671

Merged
merged 10 commits into from
May 28, 2021

Conversation

bmorelli25
Copy link
Member

Summary

  • Documents the environment variables found here.
  • Cleans up inconsistencies in the Kubernetes documentation
  • Adds env details to the Kubernetes documentation

Related

Closes #623.
Related to #645.
Related to #589.
Related to #622.

@bmorelli25 bmorelli25 requested review from ChrsMark and a team May 14, 2021 17:23
@bmorelli25 bmorelli25 self-assigned this May 14, 2021
@apmmachine
Copy link
Contributor

apmmachine commented May 14, 2021

A documentation preview will be available soon:

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone on the dev team will need to review for technical accuracy, but the writing looks great! Just a few minor comments and questions.

Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K8s part looks good to me apart from one comment I left.

@bmorelli25
Copy link
Member Author

Thanks, Chris!

@blakerouse, can you take a look at the environment variable part of this PR? There are some open review questions here that I'm hoping you'll be able to help with as well (or point me to someone who can). 🙇

@bmorelli25 bmorelli25 requested a review from blakerouse May 20, 2021 15:30
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, added 2 comments.

@bmorelli25 bmorelli25 merged commit c713636 into elastic:master May 28, 2021
@bmorelli25 bmorelli25 deleted the environment-variables branch May 28, 2021 21:10
bmorelli25 added a commit to bmorelli25/observability-docs that referenced this pull request May 28, 2021
bmorelli25 added a commit to bmorelli25/observability-docs that referenced this pull request May 28, 2021
bmorelli25 added a commit that referenced this pull request Jun 1, 2021
Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: Chris Mark <[email protected]>

Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: Chris Mark <[email protected]>
bmorelli25 added a commit that referenced this pull request Jun 1, 2021
Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: Chris Mark <[email protected]>

Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: Chris Mark <[email protected]>
bmorelli25 added a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Fleet Server environment variables
5 participants