-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Agent/Fleet Server environment variables #671
Conversation
A documentation preview will be available soon: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone on the dev team will need to review for technical accuracy, but the writing looks great! Just a few minor comments and questions.
docs/en/ingest-management/elastic-agent/configuration/env/container-envs.asciidoc
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/configuration/env/shared-env.asciidoc
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/configuration/env/shared-env.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/configuration/env/container-envs.asciidoc
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/running-on-kubernetes-standalone.asciidoc
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/configuration/env/shared-env.asciidoc
Outdated
Show resolved
Hide resolved
…ed-env.asciidoc Co-authored-by: DeDe Morton <[email protected]>
…bility-docs into environment-variables
docs/en/ingest-management/elastic-agent/running-on-kubernetes-standalone.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
K8s part looks good to me apart from one comment I left.
…standalone.asciidoc Co-authored-by: Chris Mark <[email protected]>
Thanks, Chris! @blakerouse, can you take a look at the environment variable part of this PR? There are some open review questions here that I'm hoping you'll be able to help with as well (or point me to someone who can). 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, added 2 comments.
docs/en/ingest-management/elastic-agent/configuration/env/container-envs.asciidoc
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/configuration/env/shared-env.asciidoc
Show resolved
Hide resolved
Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: Chris Mark <[email protected]>
Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: Chris Mark <[email protected]>
Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: Chris Mark <[email protected]> Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: Chris Mark <[email protected]>
Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: Chris Mark <[email protected]> Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: Chris Mark <[email protected]>
Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: Chris Mark <[email protected]>
Summary
Related
Closes #623.
Related to #645.
Related to #589.
Related to #622.