Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add changes for upload sourcemaps snippet #4763

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

david-luna
Copy link
Member

Description

The nodejs snippet provided contains an error on how to pass the file content to the request method. This PR fixes that.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

N/A

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

@david-luna david-luna added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 13, 2025
@david-luna david-luna requested a review from a team as a code owner January 13, 2025 09:53
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@colleenmcginnis colleenmcginnis added backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify labels Jan 13, 2025
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feel free to merge anytime.

Note: I added the backport-8.16 and backport-8.17 as the two most recent maintained versions assuming this change is compatible with those versions.

@david-luna david-luna merged commit 27c7b5a into main Jan 13, 2025
9 checks passed
@david-luna david-luna deleted the fix-upload-sourcemaps-snippet branch January 13, 2025 21:08
mergify bot pushed a commit that referenced this pull request Jan 13, 2025
mergify bot pushed a commit that referenced this pull request Jan 13, 2025
mergify bot pushed a commit that referenced this pull request Jan 13, 2025
colleenmcginnis pushed a commit that referenced this pull request Jan 13, 2025
(cherry picked from commit 27c7b5a)

Co-authored-by: David Luna <[email protected]>
colleenmcginnis pushed a commit that referenced this pull request Jan 13, 2025
(cherry picked from commit 27c7b5a)

Co-authored-by: David Luna <[email protected]>
colleenmcginnis pushed a commit that referenced this pull request Jan 13, 2025
(cherry picked from commit 27c7b5a)

Co-authored-by: David Luna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants