Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create agent-policies.asciidoc #469

Merged
merged 7 commits into from
Apr 14, 2021
Merged

Conversation

EricDavisX
Copy link
Contributor

This resolves
#271
#395
#394

It is likely in need of attention from someone who actually knows the docs system - but hopefully all the copy / paste of the info from those 3 tickets and a head start on {kib} and {fleet} and {agent} and {policy} and {policies} variables will help. I expect we'll want to do the same for {Elastic Package Registry} and more, but I didn't have as much a frame of reference for that so... I left it as regular old text.

In 271 Dede cited a preference to use a 'single longer' topic flow, but if this is in any way better off to be broken up, I'm all for it. so long as it gets added for our uses!

@EricDavisX EricDavisX requested review from ph and dedemorton March 26, 2021 21:31
@EricDavisX EricDavisX self-assigned this Mar 26, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Mar 26, 2021

A documentation preview will be available soon:

@EricDavisX
Copy link
Contributor Author

Dede and I spoke and are hoping to get someone with more writing focus to take it over and better it for us! :)

@bmorelli25
Copy link
Member

Hey, @EricDavisX. Thanks for opening this PR!

hoping to get someone with more writing focus

I spoke with DeDe this morning, and I'd like to help out ✋. I'm not sure how do you and DeDe typically work together on PRs like this–is it OK if I push directly to your branch?

@dedemorton
Copy link
Contributor

@bmorelli25 Sometimes I will create a branch based on the PR branch and open my own PR so that there is less noise. That way, the original contributor gets credit for their work, but I can push with abandon. But of course, it's totally up to you two. Thanks SO much for doing this work!

@EricDavisX
Copy link
Contributor Author

@bmorelli25 I don't mind if you push to that branch or do anything else with it. Whatever is quickest for you is good, and I do hope to keep the commits for reference of what work I had pushed in (my boss loves seeing it, lol). :)

@bmorelli25
Copy link
Member

👋 @EricDavisX and @elastic/obs-docs. I pushed some changes to this PR in 0263e8e. The high-level flow of the content is roughly the same, but I've moved away from long paragraph topics, to shorter, itemized lists. I started to add screenshots but realized it would probably be better to open this up to reviews before I went too far down the screenshot rabbit hole.

@bmorelli25 bmorelli25 marked this pull request as ready for review April 13, 2021 20:50
@bmorelli25 bmorelli25 requested a review from a team as a code owner April 13, 2021 20:50
Copy link
Contributor Author

@EricDavisX EricDavisX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great - thanks for the edits. the nuances on integration update needs is TBD as I noted, the team is improving this but it may not come until next release. Also in next release, the 'Integrations' tab in Fleet will be moving to a top-level application in Kibana so we'll need to figure out how to link to that and adjust each of these references to it. : /

@EricDavisX
Copy link
Contributor Author

and we can track this issue issue for updates on if we'll make changes: elastic/kibana#92612

Copy link
Contributor

@EamonnTP EamonnTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmorelli25 Just a few minor suggestions. Please feel free to take or leave them. Otherwise, it looks great!

docs/en/ingest-management/agent-policies.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/agent-policies.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/agent-policies.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/agent-policies.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/agent-policies.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/agent-policies.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/agent-policies.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/agent-policies.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/agent-policies.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/agent-policies.asciidoc Outdated Show resolved Hide resolved
@bmorelli25
Copy link
Member

bmorelli25 commented Apr 14, 2021

looks great - thanks for the edits. the nuances on integration update needs is TBD as I noted, the team is improving this but it may not come until next release.

👍 Thanks for providing elastic/kibana#92612. I've opened a documentation issue so we don't forget to update these docs for 7.13: #512.

Also in next release, the 'Integrations' tab in Fleet will be moving to a top-level application in Kibana so we'll need to figure out how to link to that and adjust each of these references to it. : /

😨 Good to know! I've opened #513 to track.


Thank you @EricDavisX for providing original content and a review and thanks @EamonnTP for the review! I have a few more commits to push based on reviews, and then we'll get this merged today 🍻

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmorelli25 bmorelli25 merged commit 6f10a79 into elastic:master Apr 14, 2021
bmorelli25 added a commit to bmorelli25/observability-docs that referenced this pull request Apr 14, 2021
Co-authored-by: EamonnTP <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: EamonnTP <[email protected]>
bmorelli25 added a commit to bmorelli25/observability-docs that referenced this pull request Apr 14, 2021
Co-authored-by: EamonnTP <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: EamonnTP <[email protected]>
bmorelli25 added a commit that referenced this pull request Apr 14, 2021
Co-authored-by: EamonnTP <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: EamonnTP <[email protected]>
Co-authored-by: Eric Davis <[email protected]>
Co-authored-by: EamonnTP <[email protected]>
bmorelli25 added a commit that referenced this pull request Apr 14, 2021
Co-authored-by: EamonnTP <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: EamonnTP <[email protected]>
Co-authored-by: Eric Davis <[email protected]>
Co-authored-by: EamonnTP <[email protected]>
@EricDavisX
Copy link
Contributor Author

#WeDidIt #MissionAccomplished - great team work, so much good stuff for our users!

bmorelli25 added a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
Co-authored-by: EamonnTP <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: EamonnTP <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants