-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom threshold rule #3314
Add custom threshold rule #3314
Conversation
A documentation preview will be available soon: |
This pull request does not have a backport label. Could you fix it @mdbirnstiehl? 🙏
|
FYI In my local tests, this new rule is also affected by elastic/kibana#162605. That is to say, it's got a "role visibility" field that you must set when you create the rule, and you can pick either "metrics" or "logs". In case it's helpful, I updated the ES query rule in the Kibana docs recently for the same new feature: https://www.elastic.co/guide/en/kibana/master/rule-type-es-query.html#_define_the_conditions_2
I think the same is likely true for this new rule (except "Stack rules" isn't one of the options here). |
Thanks, Lisa! I'll update accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good already, added some comments for clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great document and thanks for taking care of comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few little suggestions below!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
(cherry picked from commit 6705d9a)
(cherry picked from commit 6705d9a) Co-authored-by: Mike Birnstiehl <[email protected]>
This PR closes Issues 3031 and 3134.
Preview HERE