Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom threshold rule #3314

Merged
merged 13 commits into from
Nov 3, 2023

Conversation

mdbirnstiehl
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl commented Oct 27, 2023

This PR closes Issues 3031 and 3134.

Preview HERE

@github-actions
Copy link
Contributor

A documentation preview will be available soon:

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2023

This pull request does not have a backport label. Could you fix it @mdbirnstiehl? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 27, 2023
@mdbirnstiehl mdbirnstiehl added backport-8.11 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Oct 27, 2023
@mdbirnstiehl mdbirnstiehl marked this pull request as ready for review October 30, 2023 19:28
@mdbirnstiehl mdbirnstiehl requested a review from a team as a code owner October 30, 2023 19:28
@lcawl
Copy link
Contributor

lcawl commented Oct 30, 2023

FYI In my local tests, this new rule is also affected by elastic/kibana#162605. That is to say, it's got a "role visibility" field that you must set when you create the rule, and you can pick either "metrics" or "logs". In case it's helpful, I updated the ES query rule in the Kibana docs recently for the same new feature: https://www.elastic.co/guide/en/kibana/master/rule-type-es-query.html#_define_the_conditions_2

You must select a scope value, which affects the Kibana feature privileges that are required to access the rule. For example when it’s set to Stack Rules, you must have the appropriate Management > Stack Rules feature privileges to view or edit the rule.

I think the same is likely true for this new rule (except "Stack rules" isn't one of the options here).

@mdbirnstiehl
Copy link
Contributor Author

FYI In my local tests, this new rule is also affected by elastic/kibana#162605. That is to say, it's got a "role visibility" field that you must set when you create the rule, and you can pick either "metrics" or "logs". In case it's helpful, I updated the ES query rule in the Kibana docs recently for the same new feature: https://www.elastic.co/guide/en/kibana/master/rule-type-es-query.html#_define_the_conditions_2

You must select a scope value, which affects the Kibana feature privileges that are required to access the rule. For example when it’s set to Stack Rules, you must have the appropriate Management > Stack Rules feature privileges to view or edit the rule.

I think the same is likely true for this new rule (except "Stack rules" isn't one of the options here).

Thanks, Lisa! I'll update accordingly.

Copy link
Member

@maryam-saeidi maryam-saeidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good already, added some comments for clarification.

docs/en/observability/threshold-alert.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/threshold-alert.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/threshold-alert.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/threshold-alert.asciidoc Outdated Show resolved Hide resolved
@mdbirnstiehl mdbirnstiehl linked an issue Nov 1, 2023 that may be closed by this pull request
maryam-saeidi
maryam-saeidi previously approved these changes Nov 2, 2023
Copy link
Member

@maryam-saeidi maryam-saeidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great document and thanks for taking care of comments :)

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few little suggestions below!

docs/en/observability/threshold-alert.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/threshold-alert.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/threshold-alert.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/threshold-alert.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/threshold-alert.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/threshold-alert.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdbirnstiehl mdbirnstiehl merged commit 6705d9a into elastic:main Nov 3, 2023
1 check passed
@mdbirnstiehl mdbirnstiehl deleted the custom-threshold-rule branch November 3, 2023 16:29
mergify bot pushed a commit that referenced this pull request Nov 3, 2023
(cherry picked from commit 6705d9a)
mdbirnstiehl added a commit that referenced this pull request Nov 3, 2023
(cherry picked from commit 6705d9a)

Co-authored-by: Mike Birnstiehl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:ActionableObs backport-8.11 Automated backport with mergify
Projects
None yet
6 participants