Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs about package verification #2224

Merged
merged 4 commits into from
Nov 7, 2022
Merged

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Oct 5, 2022

Closes #2005

Please review. Some of the UI-related details are fuzzy because the feature is not yet turned on in the build.

Remaining questions/issues:

@dedemorton dedemorton added Team:Docs Label for the Observability docs team Team:Fleet Label for the Fleet team labels Oct 5, 2022
@dedemorton dedemorton self-assigned this Oct 5, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Oct 5, 2022

A documentation preview will be available soon:

@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2022

This pull request does not have a backport label. Could you fix it @dedemorton? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 5, 2022
@dedemorton dedemorton marked this pull request as ready for review October 12, 2022 00:02
@dedemorton
Copy link
Contributor Author

I've marked this PR as ready for review because I've taken it as far as I can without seeing the UI in a build. @hop-dev Are we still planning to turn this on for 8.5?

@dedemorton dedemorton added backport-8.5 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Oct 12, 2022
@dedemorton dedemorton requested a review from a team October 18, 2022 16:18
@dedemorton
Copy link
Contributor Author

@hop-dev Has this feature made it into 8.5? I need someone to review the content.

@mtojek Can you please respond to the question about whether the air gapped registry will have signatures?

@mrodm
Copy link
Contributor

mrodm commented Oct 19, 2022

@mtojek Can you please respond to the question about whether the air gapped registry will have signatures?

Currently, the docker images that are built for air-gapped envs and used in those Elastic Package registries do not contain the signatures. But we plan to include them soon. This change should be done after switching the DNS to start using package storage v2.

cc @jsoriano

@dedemorton
Copy link
Contributor Author

Added "blocked" label because I am blocked until https://github.com/elastic/ingest-dev/issues/1193 is merged.

@jen-huang While we're waiting for the DNS switch to v2, can someone please review the content here (and answer my questions) so that this content is ready to go when the feature goes live? Some insight into current plans would also be useful. Thanks!

@jlind23
Copy link
Contributor

jlind23 commented Nov 7, 2022

@hop-dev @kpollich could you please review this content as asked by @dedemorton ?

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - docs look good. I have filed a separate PR updating the Fleet settings docs, and if the airgapped docs need an update I think it'd be fine to file a followup.

@dedemorton dedemorton removed the blocked label Nov 7, 2022
@dedemorton
Copy link
Contributor Author

@kpollich A couple of quick follow-up questions before I merge this:

  • Which versions (if any) should I backport this to?
  • Is there an easy way to install an unverified package to confirm the details here? Or maybe that's not necessary since you have reviewed the info?

@kpollich
Copy link
Member

kpollich commented Nov 7, 2022

Which versions (if any) should I backport this to?

We can backport this to 8.5.

Is there an easy way to install an unverified package to confirm the details here? Or maybe that's not necessary since you have reviewed the info?

I don't think this is necessary. We ran through these scenarios in our testing/development cycle and everything documented here looks accurate. @hop-dev's previous review covered any of the functionality specifics, etc so I think we're good here.

@dedemorton dedemorton merged commit 8d7910b into elastic:main Nov 7, 2022
@dedemorton dedemorton deleted the issue#2005 branch November 7, 2022 19:05
mergify bot pushed a commit that referenced this pull request Nov 7, 2022
* Add docs about package verification

* Fix doc build error

* Add info based on initial round of questions

* Resolve review comments and add a pointer to Fleet Settings doc

(cherry picked from commit 8d7910b)
dedemorton added a commit that referenced this pull request Nov 8, 2022
* Add docs about package verification

* Fix doc build error

* Add info based on initial round of questions

* Resolve review comments and add a pointer to Fleet Settings doc

(cherry picked from commit 8d7910b)

Co-authored-by: DeDe Morton <[email protected]>
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
* Add docs about package verification

* Fix doc build error

* Add info based on initial round of questions

* Resolve review comments and add a pointer to Fleet Settings doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.5 Automated backport with mergify Team:Docs Label for the Observability docs team Team:Fleet Label for the Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request][Fleet] Package signatures documentation
6 participants