Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commands.asciidoc #2093

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Update commands.asciidoc #2093

merged 3 commits into from
Aug 17, 2022

Conversation

nimarezainia
Copy link
Contributor

the "non-interactive" flag was never documented.

the "non-interactive" flag was never documented.
@apmmachine
Copy link
Contributor

apmmachine commented Aug 17, 2022

A documentation preview will be available soon:

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some editorial feedback. Thanks for opening this! We'll need to forward port it to main and 8.4.

docs/en/ingest-management/commands.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/commands.asciidoc Outdated Show resolved Hide resolved
@nimarezainia nimarezainia requested review from dedemorton and removed request for AndersonQ and blakerouse August 17, 2022 20:48
Comment on lines 286 to +288

Note: if the {agent} is already installed on the host, using --force may result in
unpredictable behaviour with duplicate {agent}s appearing in {fleet}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note: if the {agent} is already installed on the host, using --force may result in
unpredictable behaviour with duplicate {agent}s appearing in {fleet}
+
NOTE: If the {agent} is already installed on the host, using `--force` may result in
unpredictable behaviour with duplicate {agent}s appearing in {fleet}.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE is required if you want this to render using the note formatting. Also added some markup for the flag name and a period at the end of the sentence.

@nimarezainia nimarezainia merged commit b3cfbb1 into 8.3 Aug 17, 2022
@nimarezainia nimarezainia deleted the nimarezainia-patch-3 branch August 17, 2022 23:48
mergify bot pushed a commit that referenced this pull request Aug 18, 2022
* Update commands.asciidoc

the "non-interactive" flag was never documented.

* Update commands.asciidoc

* Apply suggestions from code review

Co-authored-by: DeDe Morton <[email protected]>

Co-authored-by: DeDe Morton <[email protected]>

Co-authored-by: nima <[email protected]>
(cherry picked from commit 831aea0)
jsoriano pushed a commit to jsoriano/observability-docs that referenced this pull request Aug 23, 2022
* Update commands.asciidoc

the "non-interactive" flag was never documented.

* Update commands.asciidoc

* Apply suggestions from code review

Co-authored-by: DeDe Morton <[email protected]>

Co-authored-by: DeDe Morton <[email protected]>

Co-authored-by: nima <[email protected]>
ollyhowell pushed a commit to ollyhowell/observability-docs that referenced this pull request Aug 24, 2022
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
* Update commands.asciidoc

the "non-interactive" flag was never documented.

* Update commands.asciidoc

* Apply suggestions from code review

Co-authored-by: DeDe Morton <[email protected]>

Co-authored-by: DeDe Morton <[email protected]>

Co-authored-by: nima <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants