Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alerts, cases, and rules screenshots #2082

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Aug 11, 2022

Closes #1997
Closes #2002

Updates all screenshots that mention that alerts, cases, and rules are in technical preview.

cc @emma-raffenne

@colleenmcginnis colleenmcginnis requested a review from a team as a code owner August 11, 2022 15:15
@apmmachine
Copy link
Contributor

apmmachine commented Aug 11, 2022

A documentation preview will be available soon:

@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2022

This pull request does not have a backport label. Could you fix it @colleenmcginnis? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Aug 11, 2022
@colleenmcginnis colleenmcginnis added the backport-8.4 Automated backport with mergify label Aug 11, 2022
@colleenmcginnis colleenmcginnis self-assigned this Aug 11, 2022
@colleenmcginnis colleenmcginnis removed the backport-skip Skip notification from the automated backport with mergify label Aug 11, 2022
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one comment.

There's a lot of blank space at the bottom of this screenshot that we can probably remove?

Screen Shot 2022-08-15 at 10 34 28 AM

@maryam-saeidi
Copy link
Member

Regarding the rule details page and this image:
image

Recently, there was an improvement in it and now it looks like this:
image

Would you please update this image?

Copy link
Member

@maryam-saeidi maryam-saeidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve but I added one comment about updating the rule details screenshots.

@colleenmcginnis colleenmcginnis merged commit 2350c5d into elastic:main Aug 18, 2022
@colleenmcginnis colleenmcginnis deleted the issue-1997 branch August 18, 2022 16:07
mergify bot pushed a commit that referenced this pull request Aug 18, 2022
* update alerts, cases, and rules screenshots

* format screenshot

* update images

(cherry picked from commit 2350c5d)
colleenmcginnis added a commit that referenced this pull request Aug 22, 2022
* update alerts, cases, and rules screenshots

* format screenshot

* update images

(cherry picked from commit 2350c5d)

Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.4 Automated backport with mergify v8.4.0
Projects
None yet
4 participants