Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "Endpoint Security" integration references to "Endpoint and Cloud Security" #1966

Merged
merged 9 commits into from
Jul 8, 2022
Merged

Update "Endpoint Security" integration references to "Endpoint and Cloud Security" #1966

merged 9 commits into from
Jul 8, 2022

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Jun 29, 2022 •
edited
Loading

Closes #1927

@jmikell821 Can you check this and also look at the questions that begin with //REVIEWERS? I was not sure about some changes. Would appreciate your input. Thanks!

@dedemorton dedemorton requested a review from a team as a code owner June 29, 2022 23:59
@dedemorton dedemorton requested a review from jmikell821 June 30, 2022 00:00
@mergify
Copy link
Contributor

mergify bot commented Jun 30, 2022

This pull request does not have a backport label. Could you fix it @dedemorton? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jun 30, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Jun 30, 2022 •
edited
Loading

A documentation preview will be available soon:

@dedemorton dedemorton self-assigned this Jun 30, 2022
@dedemorton dedemorton added the backport-8.9 Automated backport with mergify label Jun 30, 2022
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Jun 30, 2022
joepeeples
joepeeples reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates, @dedemorton! Added two small comments for consideration.

docs/en/ingest-management/tab-widgets/remove-endpoint-files/content.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/troubleshooting/faq.asciidoc Outdated Show resolved Hide resolved
nastasha-solomon
nastasha-solomon reviewed Jul 6, 2022
View reviewed changes
Copy link

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @dedemorton ! I left a handful of comments, hopefully they're helpful!

docs/en/observability/deploy-agent-to-send-data.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/uptime-set-up.asciidoc Outdated Show resolved Hide resolved
jmikell821
jmikell821 reviewed Jul 6, 2022
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dedemorton left a few slight comments. I'm going to loop our Endpoint team on this to review as well; our team had some questions about terminology we'd like for them to verify.

docs/en/ingest-management/overview.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/troubleshooting/faq.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/troubleshooting/faq.asciidoc Outdated Show resolved Hide resolved
@dedemorton @jmikell821
Apply suggestions from code review
e9766d5 
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2022

This pull request is now in conflict. Could you fix it @dedemorton? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue#1927 upstream/issue#1927
git merge upstream/main
git push upstream issue#1927

@dedemorton dedemorton requested a review from ferullo July 6, 2022 22:50
@dedemorton
Copy link
Contributor Author

Thanks for all the feedback! I think I've gotten all the comments resolved now.

@dedemorton
Copy link
Contributor Author

Can I get final approval to merge from someone please?

joepeeples
joepeeples reviewed Jul 8, 2022
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected one tiny typo, otherwise LGTM to merge!

docs/en/ingest-management/troubleshooting/faq.asciidoc Outdated Show resolved Hide resolved
nastasha-solomon
nastasha-solomon approved these changes Jul 8, 2022
View reviewed changes
Copy link

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @dedemorton sorry for not responding sooner. Didn't find anything else outside of what @joepeeples pointed out so LGTM - thanks!

@dedemorton @joepeeples
Fix typo
790df0d 
Co-authored-by: Joe Peeples <[email protected]>
@dedemorton dedemorton merged commit 5424b37 into elastic:main Jul 8, 2022
@dedemorton dedemorton deleted the issue#1927 branch July 8, 2022 18:23
mergify bot pushed a commit that referenced this pull request Jul 8, 2022
@dedemorton @mergify
Update "Endpoint Security" integration references to "Endpoint and Cl…
8ec915e 
…oud Security" (#1966)

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
(cherry picked from commit 5424b37)
@mergify mergify bot mentioned this pull request Jul 8, 2022
Merged
dedemorton added a commit that referenced this pull request Jul 11, 2022
@mergify @joepeeples
@jmikell821 @dedemorton
Update "Endpoint Security" integration references to "Endpoint and Cl…
32830d7 
…oud Security" (#1966) (#1988)

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
(cherry picked from commit 5424b37)
Co-authored-by: DeDe Morton <[email protected]>
@joepeeples joepeeples mentioned this pull request Nov 4, 2022
Closed
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
@dedemorton @joepeeples @jmikell821
Update "Endpoint Security" integration references to "Endpoint and Cl…
7512c6a 
…oud Security" (elastic#1966)

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepeeples joepeeples joepeeples left review comments

@nastasha-solomon nastasha-solomon nastasha-solomon approved these changes

@benironside benironside Awaiting requested review from benironside

@ferullo ferullo Awaiting requested review from ferullo

@jmikell821 jmikell821 Awaiting requested review from jmikell821

Assignees

@dedemorton dedemorton

Labels
backport-8.9 Automated backport with mergify v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] Update Endpoint Security integration references to Endpoint and Cloud Security
6 participants
@dedemorton @apmmachine @ferullo @jmikell821 @nastasha-solomon @joepeeples