-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[synthetics] Document the new Synthetics Recorder #1953
Conversation
A documentation preview will be available soon: |
This pull request does not have a backport label. Could you fix it @colleenmcginnis? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So exciting, Thanks for the great work!! I can see all the important points are covered ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few comments in areas where I felt I could add some detail. Happy to follow up discussion on any of the topics.
Thanks @kyungeunni @justinkambic! I'm going to dive back into this now. 🏊 |
* Click **Export** to save a JavaScript file containing all steps. | ||
|
||
// suite --> project? | ||
You can also check **Export as a suite** and either copy and paste or **Export** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is merged to main branch but not released yet, I'm planning to release another version next week. Would you want me to capture a screenshot with updated wording? (project instead suite)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! That would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the Synthetics Recorder to generate code for one or more steps by interacting with a web page directly. | ||
|
||
// Some high-level details on what it does | ||
The recorder launches a special https://www.chromium.org/Home/[Chromium browser] that will listen to each interaction you have with the web page and record them internally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the special
wording here, AFAIK it's a normal Chromium browser that is used by Playwright.
The recorder launches a special https://www.chromium.org/Home/[Chromium browser] that will listen to each interaction you have with the web page and record them internally. | |
The recorder launches a https://www.chromium.org/Home/[Chromium browser] that will listen to each interaction you have with the web page and record them internally using Playwright. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thought WRT to "special" is that it's instrumented by Playwright, but that this semantic depth might be a bit beyond what our users know or care about the internal workings of the recorder. But yes, the actual Chromium bin is just like any other you'd find someone using.
|
||
// Some high-level details on what it does | ||
The recorder launches a special https://www.chromium.org/Home/[Chromium browser] that will listen to each interaction you have with the web page and record them internally. | ||
When you're done interacting with the page, the recorder converts the recorded actions into usable JavaScript code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor point, feel free to ignore it :)
Should we mention that the js file is only executable by Synthetics agent?
When you're done interacting with the page, the recorder converts the recorded actions into usable JavaScript code. | |
When you're done interacting with the page, the recorder converts the recorded actions into usable JavaScript code that can be executed by Synthetics agent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you're done interacting with the page, the recorder converts the recorded actions into usable JavaScript code. | |
When you're done interacting with the page, the recorder converts the recorded actions into JavaScript code for use with Elastic Synthetics. |
Maybe even something like this, dropping usable
altogether and highlighting that the code is only intended for use with Synthetics?
EDIT - we seem to cover this point in the very next sentence, so it's probably not needed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
From there you can use the code by: | ||
|
||
* Copy and pasting code containing all steps into a new or existing <<synthetic-monitor-choose-project, synthetics project>> or an <<synthetics-inline-journey, inline monitor>>. | ||
* Click **Export** to save a JavaScript file containing all steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't really say much more about why this would be used, or exists as an option (file can be dragged onto add monitor). Probably ok as we're updating this primary flow, but might be worth adding a note something for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this written up, LGTM
* initial structure, connection to instructional content add to index * first full draft * clean up text * update docs/en/observability/synthetics-recorder.asciidoc * address latest feedback * add heading ids * add beta note * add image (cherry picked from commit cdcffaf)
* initial structure, connection to instructional content add to index * first full draft * clean up text * update docs/en/observability/synthetics-recorder.asciidoc * address latest feedback * add heading ids * add beta note * add image (cherry picked from commit cdcffaf) Co-authored-by: Colleen McGinnis <[email protected]>
Closes #1907
Overview
This PR adds information on the Synthetics Recorder including:
To do
For the reviewer