Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for changes in add fleet server steps #1934

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Jun 15, 2022

Closes issue #1843

I've also applied some minor consistency edits to the content that I touched in this PR.

remaining TODOs:

@dedemorton dedemorton self-assigned this Jun 15, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2022

This pull request does not have a backport label. Could you fix it @dedemorton? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@apmmachine
Copy link
Contributor

apmmachine commented Jun 15, 2022

A documentation preview will be available soon:

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jun 15, 2022
@dedemorton dedemorton marked this pull request as ready for review June 16, 2022 04:40
@dedemorton dedemorton added v8.3.0 backport-8.9 Automated backport with mergify labels Jun 16, 2022
@dedemorton dedemorton added Team:Fleet Label for the Fleet team and removed backport-skip Skip notification from the automated backport with mergify labels Jun 16, 2022
@dedemorton dedemorton requested a review from hop-dev June 16, 2022 04:58
@colleenmcginnis
Copy link
Contributor

colleenmcginnis commented Jun 24, 2022

👋 @hop-dev can you please take a look at this PR ahead of Tuesday's release?

Copy link
Contributor

@hop-dev hop-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good, I am not sure if you're happy to merge with the CPU and memory metrics missing, I doubt we will be able to get that resolved for tomorrow.

I have put some further notes with what the quickstart mode does, but not sure if anything needs to be added.

@hop-dev
Copy link
Contributor

hop-dev commented Jun 27, 2022

Oh one last thing, the cursor is visible in the top left corner of a couple of the screenshots, not sure if that is an issue

@dedemorton
Copy link
Contributor Author

dedemorton commented Jun 29, 2022

Oh one last thing, the cursor is visible in the top left corner of a couple of the screenshots, not sure if that is an issue

That's a little sloppy, but since this PR is getting merged late, I think it's better to get the changes merged and clean up the screens later.

Actually I'll just use my screen capturing tool to edit out the cursors. :-) Simpler than doing new captures.

@dedemorton dedemorton merged commit 33fffae into elastic:main Jun 29, 2022
@dedemorton dedemorton deleted the issue#1843 branch June 29, 2022 22:09
mergify bot pushed a commit that referenced this pull request Jun 29, 2022
dedemorton pushed a commit that referenced this pull request Jun 29, 2022
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.9 Automated backport with mergify Team:Fleet Label for the Fleet team v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants