Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add Customise integration data retention documentation #1724

Merged
merged 4 commits into from
Apr 4, 2022
Merged

Re-add Customise integration data retention documentation #1724

merged 4 commits into from
Apr 4, 2022

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Mar 29, 2022

Re-add the documentation that was originally added in #1194 (and then removed in #1280) I've also removed the guidance to add a "." at the start of the component template name.

I've attempted to update the screenshots but couldn't get them the same resolution, is there a trick to do it?

@hop-dev hop-dev requested a review from bmorelli25 March 29, 2022 14:32
@hop-dev hop-dev requested a review from dedemorton as a code owner March 29, 2022 14:32
@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Mar 29, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Mar 29, 2022 •
edited
Loading

A documentation preview will be available soon:

@bmorelli25
Copy link
Member

bmorelli25 commented Mar 29, 2022 •
edited
Loading

Thanks, Mark! I ran out of time today, so I'll take a look at this tomorrow.

I've attempted to update the screenshots but couldn't get them the same resolution, is there a trick to do it?

Not sure. I'll just take some new screenshots.

Can we backport this to 8.1? Or is this for 8.2?

@bmorelli25 bmorelli25 added backport-8.2 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Mar 30, 2022
@elastic elastic deleted a comment from mergify bot Mar 30, 2022
dedemorton
dedemorton reviewed Apr 4, 2022
View reviewed changes
Copy link
Contributor

@dedemorton dedemorton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few very minor edits, but otherwise looks great and super useful!

About the screenshots...the doc build resizes them to fit the line width on the rendered page. I use the Window Resizer Chrome extension to set the viewport before capturing the screen. That helps a bit. There are some guidelines here, but TBH, I don't follow them strictly because they don't work great for product screen captures: https://wiki.elastic.co/pages/viewpage.action?pageId=69574381.

@bmorelli25 Are you still planning to work on screen captures?

docs/en/ingest-management/data-streams.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/data-streams.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/data-streams.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/data-streams.asciidoc Outdated Show resolved Hide resolved
@bmorelli25 bmorelli25 merged commit efe29f8 into elastic:main Apr 4, 2022
mergify bot pushed a commit that referenced this pull request Apr 4, 2022
@hop-dev
Re-add Customise integration data retention documentation (#1724)
c98be40 
Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: bmorelli25 <[email protected]>
(cherry picked from commit efe29f8)
@mergify mergify bot mentioned this pull request Apr 4, 2022
Merged
bmorelli25 pushed a commit that referenced this pull request Apr 4, 2022
@mergify @hop-dev
Re-add Customise integration data retention documentation (#1724) (#1756
0a9bbcb 
)

Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: bmorelli25 <[email protected]>
(cherry picked from commit efe29f8)

Co-authored-by: Mark Hopkin <[email protected]>
@hop-dev hop-dev deleted the customise-integration-data-retention branch April 5, 2022 09:17
@hop-dev hop-dev mentioned this pull request Apr 5, 2022
Closed
bmorelli25 added a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
@hop-dev @dedemorton @bmorelli25
Re-add Customise integration data retention documentation (elastic#1724)
283ce35 
Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: bmorelli25 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedemorton dedemorton dedemorton left review comments

@bmorelli25 bmorelli25 bmorelli25 approved these changes

Assignees
No one assigned
Labels
backport-8.2 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hop-dev @apmmachine @bmorelli25 @dedemorton