Add aws/auth action #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reakaleek
force-pushed
the
feature/aws-auth
branch
2 times, most recently
from
05fd3d1 to
258e7f5
Compare
reakaleek
force-pushed
the
feature/aws-auth
branch
from
258e7f5 to
3a1d318
Compare
v1v
reviewed
Jun 20, 2024
aws/auth/action.yml
Outdated
| m.update(f"{repository}/{worflow_filename}".encode('utf-8')) | ||
| hash = m.hexdigest()[:55] | ||
| role_name = f"gha-{hash}-role" | ||
| role_arn = f"arn:aws:iam::697149045717:role/{role_name}" |
There was a problem hiding this comment.
Could you customise this? We may use some other AWS accounts in the near future
aws/auth/action.yml
Outdated
| with open(os.environ['GITHUB_OUTPUT'], 'a') as f: | ||
| f.write(f"role-arn={role_arn}") | ||
|
|
||
| - name: Configure AWS Credentials for China region audience |
aws/auth/action.yml
Outdated
| f.write(f"role-arn={role_arn}") | ||
|
|
||
| - name: Configure AWS Credentials for China region audience | ||
| uses: aws-actions/configure-aws-credentials@v4 |
There was a problem hiding this comment.
v1v
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was successfully tested in https://github.com/elastic/apm-aws-lambda/actions/runs/9597412100/workflow?pr=491