Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deploy-my-kibana): use github secrets #142

Merged
merged 14 commits into from
Oct 8, 2024
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Oct 7, 2024

What

Replace https://github.com/elastic/apm-pipeline-library/tree/main/.github/actions/deploy-my-kibana with GitHub secrets and support only for no serverless.

Issues

Requires #143

Test

See #59 (comment)

image

and a link to the GH private repository can be seen in this PR

image

@v1v v1v added the changelog:feature When you add a new feature label Oct 7, 2024
@v1v v1v self-assigned this Oct 7, 2024
Comment on lines 30 to 33
comment_url: https://github.com/elastic/kibana/pull/195219#issuecomment-2397814616
comment_id: 2397814616
issue_url: https://api.github.com/repos/elastic/kibana/issues/195219
repository: 'elastic/kibana'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use elastic/kibana#195219 (comment), however the command is not what we use in production, but wanted to use a real GitHub comment but using a PR owned by me - to avoid spamming people

Copy link
Member Author

@v1v v1v Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the comment to be used so i could benefit from the default permissions at the workflow level, the GH app does not have permissions to all the GH repositories but jus a subset... so using the GH actions permissions we can simplify the need to add more GH repositories

@v1v v1v marked this pull request as ready for review October 7, 2024 21:48
@v1v v1v requested a review from a team October 7, 2024 21:48
| `comment-id` | The GitHub Comment ID | `false` | `${{ github.event.comment.id }}` |
| `issue-url` | The GitHub Issue URL | `false` | `${{ github.event.comment.issue_url }}` |
| `repository` | The GitHub repository | `false` | `${{ github.repository }}` |
| `user` | The GitHub user that triggered the workflow | `false` | `${{ github.triggering_actor }}` |
Copy link
Member

@reakaleek reakaleek Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just took a look at https://github.com/elastic/oblt-actions/tree/main/github/is-member-of

and I feel like we have an inconsistency with naming inputs.

This is not blocking, but we might want to think about when to prefix with github- or not.

maybe we can revisit this when we eventually need to release v2

Comment on lines +55 to +56
installation_retrieval_mode: organization
installation_retrieval_payload: elastic
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #144

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reakaleek , if you use the GH app action in a GH repository which does not have installed the GH app, then you need these two parameters, otherwise you will see some errors like the ones in #144

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, interesting. thanks for the info

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installation_retrieval_mode: id
...

does not work, see tibdex/github-app-token#102

@v1v v1v enabled auto-merge (squash) October 8, 2024 07:49
@v1v v1v merged commit 9780588 into main Oct 8, 2024
12 checks passed
@v1v v1v deleted the feature/deploy-my-kibana-1 branch October 8, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:feature When you add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants