feat: support wait for maven central #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainJuge
approved these changes
Sep 23, 2024
SylvainJuge
reviewed
Sep 23, 2024
maven/await-artifact/README.md
Outdated
| | `artifact-id` | Maven artifact-ID of the artifact | `true` | ` ` | | ||
| | `group-id` | Maven group-ID of the artifact | `true` | ` ` | | ||
| | `version` | Version of the artifact to wait for | `true` | ` ` | | ||
| | `wait-for-maven-central` | Whether to wait for the artifact to be available in the maven central repository. | `false` | `false` | |
There was a problem hiding this comment.
maybe add as footnote that when set to false, only the sonatype repository is checked, which is usually fine for snapshots, but for releases checking maven central might be preferable as the sonatype proxy repo might not reflect actual maven central state.
There was a problem hiding this comment.
Sure thing
For the record, I decided to use this approach to avoid a breaking change since it's a change of behaviour
There was a problem hiding this comment.
what do you think with the new changes? 61f4cc5
I added a longer description and also a new flag to support whether to validate sonatype or maven or both.
There was a problem hiding this comment.
Looks good to me, adding a sentence to explain when to change the default for wait-for-maven-central might be welcome:
- with default value, we just wait for the publication to complete on sonatype, but the actual availability in maven central might not be ready yet.
- with
truewe wait for the artifact to be published in maven central, this should be used when building other artifacts by downloading from maven central, which is for example quite common for docker images.
v1v
commented
Sep 23, 2024
SylvainJuge
approved these changes
Sep 24, 2024
reakaleek
approved these changes
Sep 24, 2024
v1v
commented
Sep 24, 2024
I agree , see f3969cb |
v1v
added a commit
to v1v/oblt-actions
that referenced
this pull request
Oct 7, 2024
…ibana * upstream/main: (51 commits) deps: Bump oblt-cli version to 7.6.2 (elastic#139) feat: undeploy-my-kibana (elastic#140) build(deps): bump the github-actions group across 2 directories with 2 updates (elastic#141) build(deps): bump the github-actions group across 6 directories with 1 update (elastic#138) chore: deps(oblt-cli): Bump oblt-cli version to 7.5.24 (elastic#137) feat: support wait for maven central (elastic#133) feat: migrate is-member-elastic-org (elastic#135) deps: Bump oblt-cli version to 7.5.22 (elastic#131) deps(updatecli): bump all policies (elastic#130) ci: use GitHub app for ephemeral tokens (elastic#129) Deprecate the `project-id` input in `google/auth` action. (elastic#124) deps(updatecli): bump all policies (elastic#122) chore: deps(oblt-cli): Bump oblt-cli version to 7.5.21 (elastic#121) build(deps): bump the github-actions group across 11 directories with 4 updates (elastic#125) github-action: use ephemeral tokens with the required permissions (elastic#113) feat(github): validate-comment (elastic#120) feat(pre-commit): migrate from apm-pipeline-library (elastic#119) deps(updatecli): bump all policies (elastic#117) feat(await-maven-artifact): migrate from https://github.com/elastic/apm-pipeline-library (elastic#118) Add `test-report` action (elastic#114) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #132
What
Support to query the maven central if
wait-for-maven-centralis set totrueby default is not the case.