[DOCS] Edits 6.5.4 release notes entries #346
Conversation
docs/CHANGELOG.asciidoc
Outdated
| in apparently shifted model plot with respect to the data and increased errors in forecasts. | ||
| Corrects query times for model bounds and forecasts in the bucket to match the | ||
| times assigned to the samples that are added to the model for each bucket. For | ||
| long bucket lengths, this fix could result in apparently shifted model bounds |
There was a problem hiding this comment.
I think this line needs changing as it refers to the situation before the fix. One possibility would be to simply remove the word "fix". Or if you want the word "fix" to appear somewhere, another way would be to completely flip the paragraph:
Fixes a problem that could result in shifted model bounds and increased forecast errors with long bucket spans. The change was to correct query times for model bounds and forecasts in the bucket to match the times assigned to the samples that are added to the model for each bucket. (See {ml-pull}327[#327].)
There was a problem hiding this comment.
or possibly "fix" -> "bug", but I think I maybe prefer Dave's suggestion
|
LGTM2 (with the issue resolved). |
|
Thanks for the feedback! I've updated the text |
This PR edits the ml-cpp entries for inclusion in the Elasticsearch 6.5.4 release notes. In particular, it references the following PR: #327