[ML] Write out forecasts predictions at "bucket time" rather than the actual times they are made in the time buckets #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droberts195
approved these changes
Dec 7, 2018
|
Thanks. Will do. |
This was referenced Dec 7, 2018
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jan 3, 2019
The problem that caused the test to be muted was fixed in elastic/ml-cpp#332 Closes elastic#36258
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Jan 3, 2019
The problem that caused the test to be muted was fixed in elastic/ml-cpp#332 Closes #36258
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Jan 3, 2019
The problem that caused the test to be muted was fixed in elastic/ml-cpp#332 Closes #36258
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Jan 3, 2019
The problem that caused the test to be muted was fixed in elastic/ml-cpp#332 Closes #36258
droberts195
added a commit
to elastic/elasticsearch
that referenced
this pull request
Jan 3, 2019
The problem that caused the test to be muted was fixed in elastic/ml-cpp#332 Closes #36258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java notion of "bucket time" is the start of a job's time buckets, i.e. if the job uses 30 minute time buckets then the "bucket time" is the start of each 30 minute time interval (from 00:00:00 in UTC). Currently, all anomaly detection results are written at bucket time for the buckets which contain them.
As a result of #327, we started evaluating forecasts at the sample offset in the time bucket (for good reasons). In addition, we reported their times as at the evaluation time rather than "bucket time" for the bucket which contains them. This change reverts to report them at bucket time.
Going forward we will probably want to revisit this behaviour and decouple the notion of bucket time from forecast documents. They would simply hold a time and the forecast at that time, whatever time that may be. However, this requires knock on changes to our UI, which we don't want to make now, and makes more sense in the context of planned changes to the forecast API.
I've marked this as a non-issue, as it is a change to revert behaviour introduced in #327 which is not yet released.