[ML] Upgrade Gradle to v5.0 #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs to be merged before elastic/elasticsearch#34263 to prevent builds with ml-cpp in elasticsearch-extra from failing. Defining a custom wrapper task was incompatible with Gradle 5, so this is replaced with a modification to the built in wrapper task. The Gradle Wrapper is also upgraded to the latest version.
alpar-t
approved these changes
Dec 4, 2018
|
@atorok I think the wrapper jar is already updated to the correct version in this PR - search for "Binary file not shown" on the "Files changed" tab. The change in file size is different to elastic/elasticsearch#34263, but I think that's because the previous version of Gradle being used was different between the two repos. Just in case I ran |
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Dec 4, 2018
Needs to be merged before elastic/elasticsearch#34263 to prevent builds with ml-cpp in elasticsearch-extra from failing. Defining a custom wrapper task was incompatible with Gradle 5, so this is replaced with a modification to the built in wrapper task. The Gradle Wrapper is also upgraded to the latest version.
droberts195
added a commit
that referenced
this pull request
Dec 4, 2018
Needs to be merged before elastic/elasticsearch#34263 to prevent builds with ml-cpp in elasticsearch-extra from failing. Defining a custom wrapper task was incompatible with Gradle 5, so this is replaced with a modification to the built in wrapper task. The Gradle Wrapper is also upgraded to the latest version. Backport of #325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be merged before elastic/elasticsearch#34263 to
prevent builds with ml-cpp in elasticsearch-extra from
failing.
Defining a custom wrapper task was incompatible with
Gradle 5, so this is replaced with a modification to the
built in wrapper task.
The Gradle Wrapper is also upgraded to the latest version.