Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Linux build fixes #2346

Merged
merged 2 commits into from
Jul 6, 2022
Merged

[ML] Linux build fixes #2346

merged 2 commits into from
Jul 6, 2022

Conversation

edsavage
Copy link
Contributor

@edsavage edsavage commented Jul 5, 2022

  • Flags for position independent executables
  • Always set the _REENTRANT flag
  • Typo in 3rd_party.cmake

* Flags for position independent executables
* Always set the _REENTRANT flag
* Typo in 3rd_party.cmake
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a couple of minor nits

cmake/functions.cmake Outdated Show resolved Hide resolved
3rd_party/3rd_party.cmake Outdated Show resolved Hide resolved
@droberts195
Copy link
Contributor

retest

@edsavage edsavage merged commit a907c92 into elastic:main Jul 6, 2022
@edsavage edsavage deleted the linux_build_fixes branch July 6, 2022 08:06
droberts195 added a commit to elastic/elasticsearch that referenced this pull request Jul 6, 2022
The most recent problem should be fixed by elastic/ml-cpp#2346

Fixes #88090
Fixes #88252
2lambda123 pushed a commit to 2lambda123/elastic-elasticsearch that referenced this pull request May 3, 2024
The most recent problem should be fixed by elastic/ml-cpp#2346

Fixes #88090
Fixes #88252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants