[ML] Upgrade to PyTorch 1.11 on Windows #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no changes to the build process since 1.9. We still don't ship with MKL on Windows. The size of MKL proved controversial on Linux, so it's best not to increase distribution size even further by adding in the Windows version. (We can still revisit this in the future if there's sufficient demand for NLP in production on Windows.)
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Mar 22, 2022
Together with elastic#2233 and elastic#2235 this completes the upgrade to PyTorch 1.11 for all platforms. A small change to the way things are done is that we now copy all MKL libraries into the Docker images, then copy the required subset into our release distribution. This means we can change the subset of MKL libraries that we redistribute without having to rebuild our Docker images. Fixes elastic#2126
droberts195
added a commit
that referenced
this pull request
Mar 30, 2022
Together with #2233 and #2235 this completes the upgrade to PyTorch 1.11 for all platforms. A small change to the way things are done is that we now copy all MKL libraries into the Docker images, then copy the required subset into our release distribution. This means we can change the subset of MKL libraries that we redistribute without having to rebuild our Docker images. Fixes #2126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no changes to the build process since 1.9.
We still don't ship with MKL on Windows. The size of MKL proved
controversial on Linux, so it's best not to increase distribution
size even further by adding in the Windows version. (We can still
revisit this in the future if there's sufficient demand for NLP
in production on Windows.)