Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Remove redundant autodetect options #1663

Merged
merged 3 commits into from
Jan 13, 2021

Conversation

edsavage
Copy link
Contributor

Remove the now redundant autodetect command line options and
exit with error message on seeing unknown command line arguments

Remove the now redundant autodetect command line options and
exit wit error message on seeing unknown command line arguments
bin/autodetect/CCmdLineParser.cc Outdated Show resolved Hide resolved
bin/autodetect/Main.cc Outdated Show resolved Hide resolved
bin/autodetect/CCmdLineParser.cc Outdated Show resolved Hide resolved
bin/autodetect/CCmdLineParser.cc Outdated Show resolved Hide resolved
bin/autodetect/CCmdLineParser.cc Outdated Show resolved Hide resolved
bin/autodetect/CCmdLineParser.cc Show resolved Hide resolved
bin/autodetect/CCmdLineParser.h Outdated Show resolved Hide resolved
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you could just delete 1 more redundant line

bin/autodetect/Main.cc Outdated Show resolved Hide resolved
@edsavage edsavage merged commit 85d0ca4 into elastic:master Jan 13, 2021
edsavage added a commit to edsavage/ml-cpp that referenced this pull request Jan 13, 2021
Remove the now redundant autodetect command line options and
exit with error message on seeing unknown command line arguments

Relates elastic#1253
@edsavage edsavage deleted the reject_redundant_options branch January 13, 2021 15:10
edsavage added a commit that referenced this pull request Jan 13, 2021
Remove the now redundant autodetect command line options and
exit with error message on seeing unknown command line arguments

Relates #1253
Backports #1663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants