Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Leniency parsing background_persist_interval #1662

Merged
merged 1 commit into from
Jan 13, 2021
Merged

[ML] Leniency parsing background_persist_interval #1662

merged 1 commit into from
Jan 13, 2021

Conversation

edsavage
Copy link
Contributor

Be more lenient when parsing the background_persist_interval field as it is:

  1. optional and
  2. not present in the job config in the majority of cases

@edsavage
[ML] Leniency parsing background_persist_interval
311a1c5 
Be more lenient when parsing the background_persist_interval field as it
is a) optional and b) not present in the job config in the majority of
cases
droberts195
droberts195 approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edsavage
Copy link
Contributor Author

retest

@edsavage edsavage merged commit eb8bcb7 into elastic:master Jan 13, 2021
edsavage added a commit to edsavage/ml-cpp that referenced this pull request Jan 13, 2021
@edsavage
[ML] Leniency parsing background_persist_interval (elastic#1662)
2f6e69e 
Be more lenient when parsing the background_persist_interval field as it
is a) optional and b) not present in the job config in the majority of
cases

relates elastic#1253, elastic#1648
edsavage added a commit that referenced this pull request Jan 13, 2021
@edsavage
[7.x][ML] Leniency parsing background_persist_interval (#1662) (#1665)
a043c74 
Be more lenient when parsing the background_persist_interval field as it
is a) optional and b) not present in the job config in the majority of
cases

Relates #1253, #1648
Backports #1662
@edsavage edsavage deleted the relax_background_persist_interval_parsing branch January 13, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droberts195 droberts195 droberts195 approved these changes

Assignees
No one assigned
Labels
:ml >non-issue review v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edsavage @droberts195