[7.11][ML] Improve program counter resets between unit tests #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Program counters are implemented as a singleton object, which means their values spill between unit tests unless action is taken to prevent this. Often it doesn't matter, as most unit tests do not care about program counter values. Two unit test suites already reset program counters in between tests: CProgramCountersTest and CRestorePreviousStateTest. It turns out that a third test suite should have been resetting counters but wasn't: CDataFrameAnalysisInstrumentationTest. This PR rectifies that omission and also factors out the code used to reset counters into the test library which makes it easier to reuse if other suites also need the functionality in the future. Backport of elastic#1656
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Program counters are implemented as a singleton object,
which means their values spill between unit tests unless
action is taken to prevent this. Often it doesn't matter,
as most unit tests do not care about program counter
values.
Two unit test suites already reset program counters in
between tests: CProgramCountersTest and
CRestorePreviousStateTest.
It turns out that a third test suite should have been
resetting counters but wasn't:
CDataFrameAnalysisInstrumentationTest.
This PR rectifies that omission and also factors out the
code used to reset counters into the test library which
makes it easier to reuse if other suites also need the
functionality in the future.
Backport of #1656