Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix wrong model metadata label #1655

Merged
merged 3 commits into from
Jan 12, 2021

Conversation

valeriy42
Copy link
Contributor

When I was writing model metadata hyperparameters in #1627 , I was outputting eta values and was using downsample_factor label. This RP fixes this.

Copy link
Contributor

@edsavage edsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valeriy42 valeriy42 merged commit 6dd0fcd into elastic:master Jan 12, 2021
@valeriy42 valeriy42 deleted the modelmetadata-eta-fix branch January 12, 2021 15:13
valeriy42 added a commit to valeriy42/ml-cpp that referenced this pull request Jan 12, 2021
When I was writing model metadata hyperparameters in elastic#1627 , I was outputting eta values and was using downsample_factor label. This RP fixes this.
valeriy42 added a commit that referenced this pull request Jan 12, 2021
When I was writing model metadata hyperparameters in #1627 , I was outputting eta values and was using downsample_factor label. This RP fixes this.

Backport of #1655.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants